Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tcp Session Close #49

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Tcp Session Close #49

merged 6 commits into from
Dec 2, 2024

Conversation

compscidr
Copy link
Owner

@compscidr compscidr commented Dec 2, 2024

  • Avoid acquiring locks and processing when the Tcp session is already in the closed state
  • Unregister selectors when remote side fails

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.80%. Comparing base (1dd7c69) to head (2e22837).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/kotlin/com/jasonernst/kanonproxy/Session.kt 80.00% 1 Missing ⚠️
...m/jasonernst/kanonproxy/tcp/AnonymousTcpSession.kt 66.66% 1 Missing ⚠️
...kotlin/com/jasonernst/kanonproxy/tcp/TcpSession.kt 50.00% 0 Missing and 1 partial ⚠️
...kotlin/com/jasonernst/kanonproxy/udp/UdpSession.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #49      +/-   ##
============================================
- Coverage     62.36%   61.80%   -0.56%     
  Complexity      218      218              
============================================
  Files            15       15              
  Lines          1897     1901       +4     
  Branches        283      284       +1     
============================================
- Hits           1183     1175       -8     
+ Misses          551      550       -1     
- Partials        163      176      +13     
Flag Coverage Δ
libunittests 61.80% <66.66%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compscidr compscidr merged commit 65b521f into main Dec 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant