PCHR-3424: Import styles from Bootstrapcivihr #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorpavlov-zz
changed the title
igorpavlov-zz
force-pushed
the
PCHR-3424-remove-bootstrapcivihr-from-ssp
branch
from
b6e1553 to
6f00470
Compare
AkA84
approved these changes
Jul 24, 2018
igorpavlov-zz
force-pushed
the
PCHR-3424-remove-bootstrapcivihr-from-ssp
branch
from
ba8a74e to
8d519bc
Compare
igorpavlov-zz
force-pushed
the
PCHR-3424-remove-bootstrapcivihr-from-ssp
branch
from
8d519bc to
31ba70b
Compare
AkA84
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In compucorp/civihr-employee-portal#523 we remove the Bootstrapcivihr from SSP. This leads to visual regressions as some styles are missing:
This PR imports the partials containing these styles from Bootstrapcivihr into SSP Theme.
Before
After
Technical Details
Simply import the partials:
Comments
It was discovered, that the files for "fonts" for the logo icons were not working. The logo fonts worked when Bootstrapcivihr was used because it contained correct font files. This was fixed by simply copying the font files from Bootstrapcivihr and replacing the font files in SSP with them.
✅Manual Tests - passed
✅CSS distributive files - included
✅Backstop tests - passed