Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCHR-4049: Upgrade gulp #403

Merged
merged 9 commits into from
Aug 6, 2018
Merged

PCHR-4049: Upgrade gulp #403

merged 9 commits into from
Aug 6, 2018

Conversation

igorpavlov-zz
Copy link
Contributor

@igorpavlov-zz igorpavlov-zz commented Jul 31, 2018

Overview

This PR is upgrading Gulp to the version 4.0.

Technical Details

Basic changes

Please refer to compucorp/civihr#2804 to see the basic technical details that were also applied in this PR.

Compass

If Compass or/and Compass-Bootstrap is not yet installed on the computer gulp will not show any error and the css file will not be updated. To prevent this an error is now shown:

// The app style relies on compass's gems,
// so we need to rely on it for the time being
exec('compass compile', function (error, stdout) {
  if (error) {
    console.log(error);

Gulp tested (deleted dist files and successfully rebuilt without changes)
Requirejs tested
Test tested
Sass tested
Watch tested

package.json Outdated
@@ -70,5 +61,16 @@
"stylelint-order": "^0.8.1",
"stylelint-scss": "^2.5.0",
"yargs": "^11.1.0"
},
"dependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are still dev dependencies, not dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, my bad, I seem to have installed without --save-dev flag.

@igorpavlov-zz igorpavlov-zz force-pushed the PCHR-4049-upgrade-gulp branch from 08217ed to 296cee5 Compare August 1, 2018 15:57
@igorpavlov-zz igorpavlov-zz merged commit d3c198f into staging Aug 6, 2018
@igorpavlov-zz igorpavlov-zz deleted the PCHR-4049-upgrade-gulp branch August 6, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants