-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCHR-4049: Upgrade gulp #403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorpavlov-zz
force-pushed
the
PCHR-4049-upgrade-gulp
branch
from
July 31, 2018 13:51
ce4fd29
to
07c8f0f
Compare
AkA84
suggested changes
Aug 1, 2018
package.json
Outdated
@@ -70,5 +61,16 @@ | |||
"stylelint-order": "^0.8.1", | |||
"stylelint-scss": "^2.5.0", | |||
"yargs": "^11.1.0" | |||
}, | |||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are still dev dependencies, not dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, my bad, I seem to have installed without --save-dev
flag.
AkA84
approved these changes
Aug 1, 2018
igorpavlov-zz
force-pushed
the
PCHR-4049-upgrade-gulp
branch
from
August 1, 2018 15:57
08217ed
to
296cee5
Compare
AkA84
approved these changes
Aug 2, 2018
AkA84
approved these changes
Aug 3, 2018
AkA84
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is upgrading Gulp to the version
4.0
.Technical Details
Basic changes
Please refer to compucorp/civihr#2804 to see the basic technical details that were also applied in this PR.
Compass
If Compass or/and Compass-Bootstrap is not yet installed on the computer gulp will not show any error and the css file will not be updated. To prevent this an error is now shown:
✅Gulp tested (deleted dist files and successfully rebuilt without changes)
✅Requirejs tested
✅Test tested
✅Sass tested
✅Watch tested