PCHR-3545: Changed Order For Individual Prefix #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backstageel
changed the base branch from
staging
to
PCHR-3536-Display-Preferences
|
Can you provide screenshot for the |
ajesamson
reviewed
Jun 19, 2018
| $newWeight = 2; | ||
| break; | ||
|
|
||
| case "Ms.": |
There was a problem hiding this comment.
Kindly replace with single quote
ajesamson
reviewed
Jun 19, 2018
| $newWeight = 4; | ||
| break; | ||
|
|
||
| case "Dr.": |
There was a problem hiding this comment.
Single quote here as well
ajesamson
reviewed
Jun 19, 2018
|
|
||
| /** | ||
| * Changes The Order of Individual Prefixes | ||
| * |
There was a problem hiding this comment.
You can remove this extra line.
backstageel
force-pushed
the
PCHR-3545-Change-Order-For-Individual-Prefix
branch
from
17ddeb3 to
be1ed18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Change order of individual prefix options to:
Before
The order used was the default for CiviCRM.
After