SHOR-22: Remove extra PHP code for appending contact image - covered under shoreditch

[swastikpareek]

Overview

HRUI component enforces a feature which actually fetch the image URL and appends it near the contact title. If we see Plain CiviCRM the Image is already appearing in the DOM we just need to move it to the position.

Since this change is required in CiviCRM too we have moved this feature to shoreditch - refer - civicrm/org.civicrm.shoreditch#264

Before

After

[AkA84]

@swastikpareek this is approved, but you need to amend the PR description

you have a “Core overrides” section, but that section should not be there. You are not overriding core CiviCRM files, you are simply working on our own files.

Another observation about the "Technical Details" section: there isn't really much here to describe. This section is used to detail important aspects of your solution, but here you are

1. Stating the obvious by simply copy-pasting the lines of code you removed
2. Listing the code lines that you worked on. That's what the "Files changed" tab is for.
3. Restating the reason for the changes. You already explained it in the "overview", there is no need to repeat it, especially in this section
4. Mentioning the move of the feature to Shoreditch. Again you already say that and in any case it's not even a technical detail

In short: if you have something interesting/important to say to the fellow dev who will read this PR, then put it in the "Technical Details" section. If you don't have it, then do no add the section at all

[swastikpareek]

Closing this PR as it is raised as with a different base fork. Refer - #2810