-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCHR-4098: Misc BackstopJS fixes and improvements #2818
Conversation
0f6ff40
to
639c60b
Compare
639c60b
to
ea6131c
Compare
ea6131c
to
4cdd46a
Compare
Please remove the |
You update BS to 3.5.0, could you please mention that in the PR desc? |
The PR description is misleading. You specify version 3.5.0 too prominently, in the header, so if someone skims the PR, they may miss the point that it is actually 3.5.2 version that is used. Thus I suggest the following desc structure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR desc as suggested above or suggest our own version that addresses the issue described above.
This PR contains miscellaneous improvements and fixes to CiviHR's backstopjs set up
Updating to latest stable BackstopJS version
Update BackstopJS to the beta version, currentlyv3.5.0
. The rationale behind this decision is the same as the one described hereUsing the beta version caused an issue in which a node package was not properly installed when running
npm i
in the civihr root, thus causinggulp
commands to not executeI couldn't find the reason for it, so instead of using the beta version I used the latest stable version (
v3.5.2
). It doesn't contain the improvement that the beta contains, but it's at least stableFixed AngularJS urls
After #2790 , the format of urls of angular apps have changed, for example:
which broke BackstopJS scenarios where we used those urls directly
This PR fixes the urls
Fixed selector for edit my details button
The worked done in as part of compucorp/civihr-employee-portal#520 changed the
href
value of the "Edit my details" button,which resulted in the "SSP / Edit My Details" as its script relied on the value of
href
, and didn't get updated. The PR fixes the issue by updating the selector