remove relevance in sort order when no query string is present #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t be visible for /codebases/
Desired behavior: ``` | ordering | qs | default_ordering | criteria['ordering'] | |----------|-------|--------------------|------------------------| | True | True | "relevance" | ordering | | True | False | "-first_published_at" | ordering | | False | True | "relevance" | "relevance" | | False | False | "-first_published_at" | "-first_published_at" | ```
alee
force-pushed
the
sort_order_relevance_patch
branch
from
65bfae2 to
8bf3f5d
Compare
instead of passing strings around and interpreting them downstream, set order_by_relevance directly in the search_backend ES call
…y Filters" for Event and Jobs
…on the sidebars: Codebase, Event, Jobs, Profile
alee
commented
Oct 24, 2024
There was a problem hiding this comment.
thanks Anton! Is the entire clearAllFilters machinery used? I don't think it gets called by anything live in ListSidebar.vue or elsewhere.
Setting isFilterChanged to true appears to enable Apply Filters always instead of only when there are filters to apply though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked anton's commit 376bc27 from #769 and laid over main instead of the defunct squashed + merged branch