Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: order MemberProfile search results by relevance when searching /users/?query=... #784

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: order MemberProfile search results by relevance when searching /users/?query=... #784

wants to merge 1 commit into from
+1 −1

Conversation

asuworks
Copy link
Contributor

No description provided.

@asuworks asuworks requested a review from sgfost December 20, 2024 23:20
sgfost
sgfost reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@sgfost sgfost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well thats an easy fix. Should order_by_relevance just default to True? Categorically, there are only two cases where we don't want to order by relevance (no query at all OR explicit "sort by"), right?

@asuworks
Copy link
Contributor Author

yeah :) yes, it could be set to True by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgfost sgfost sgfost left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asuworks @sgfost