Make yarn-run-dev not move queries.json to build folder #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubensworks
reviewed
Sep 20, 2024
package.json
Outdated
| @@ -51,7 +51,7 @@ | |||
| ], | |||
| "scripts": { | |||
| "lint": "eslint src/*.js", | |||
| "dev-prod": "comunica-compile-config config/config-default.json > .tmp-comunica-engine.js && ./bin/queries-to-json.js && webpack serve --config webpack.config.js --mode production", | |||
| "dev-prod": "comunica-compile-config config/config-default.json > .tmp-comunica-engine.js && ./bin/queries-to-json.js && webpack serve --config webpack.config.dev.js --mode production", | |||
There was a problem hiding this comment.
Are you sure this is correct. AFAICS, webpack.config.dev.js does not exist?
There was a problem hiding this comment.
Forgot to commit my change, fixed now!
rubensworks
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Thanks @simonvbrae, looks good!
Can you confirm build and serving works correctly in these cases? (because the CI currently only checks one of these)
yarn run dev(yarn run dev-prodshould be the same)yarn run buildnode bin/generate.js
If yes, I'll merge this right away!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR, I am still making changes.
Calling
yarn run devwould result in the queries.json file being moved tobuild/after generation resulting in missing data sources and queries in the development server.This PR changes lets that
movehappen outside of webpack so it doesn't happen when runningyarn run dev, only when runningyarn run build.