Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for circle-ci #124

Closed
yarikoptic opened this issue Jul 1, 2021 · 17 comments · Fixed by #164
Closed

Add support for circle-ci #124

yarikoptic opened this issue Jul 1, 2021 · 17 comments · Fixed by #164
Assignees

Comments

@yarikoptic
Copy link
Member

e.g. for dandi-api which still uses it.

@jwodder
Copy link
Member

jwodder commented Jul 19, 2022

@yarikoptic Does dandi-api still use Circle CI? Can I be added to a repository on Circle CI so that I can test out the API?

@yarikoptic
Copy link
Member Author

Actually I don't know if dandi-archive uses circle-ci any longer. Current target is https://github.com/bids-standard/bids-specification/ . Do you need to be "added" to get Read-only access ?

@jwodder
Copy link
Member

jwodder commented Jul 19, 2022

@yarikoptic I can access at least some part of the API for that project. I'll let you know if anything seems to require being added.

@jwodder
Copy link
Member

jwodder commented Jul 19, 2022

@yarikoptic It appears I need to be "following" the bids-specification repository (or its pipelines) on Circle CI in order to see anything meaningful, and this apparently requires that I have some sort of access to the bids-standard organization on Circle CI.

@yarikoptic
Copy link
Member Author

are you logged in via github there or have some dedicated different login?

@yarikoptic
Copy link
Member Author

I will request addition of you to bids-standard but may be meanwhile could create some primitive setup for testing https://github.com/con/tinuous-inception to iron support on?

@jwodder
Copy link
Member

jwodder commented Jul 20, 2022

@yarikoptic I'm logged in via GitHub.

Do you really mean tinuous-inception (in which case I presume it would just fetch logs and do nothing) or tinuous itself?

@yarikoptic
Copy link
Member Author

right -- add circle-ci to tinuous (as we did for travis/appveyor etc) so tinuous-inception could fetch them "as a test".

@jwodder
Copy link
Member

jwodder commented Jul 20, 2022

@yarikoptic I sent you (I assume) a request to enable Circle CI for the "con" organization.

@jwodder
Copy link
Member

jwodder commented Jul 20, 2022

@yarikoptic Here's what I've found & figured out about fetching Circle CI logs so far:

  • Circle CI has two versions of its API, v1.1 and v2. A notice at the top of the v1.1 docs states "v1 APIs will be deprecated within the next year. We recommend switching to the v2 APIs."
  • I cannot find a way to get logs via the v2 API
  • This post describes a way to get logs via the v1.1 API, but trying that led me to an S3 URL with an empty response body.
  • By inspecting the URLs of the logs links in the web interface, I determined that I can get the logs for a step via the v1.1 API by making a request to /api/v1.1/project/github/:org/:name/:build_num/output/:step/0?file=true. I'm not sure of the meaning of the /0 at the end, but I think it may have to do with parallel runs.

@yarikoptic
Copy link
Member Author

could you post a question on https://discuss.circleci.com/ about v2 API for the logs? would be sad to get support implemented just to see it "gone" within a year.

@jwodder
Copy link
Member

jwodder commented Jul 21, 2022

@yarikoptic Question posted: https://discuss.circleci.com/t/downloading-build-logs-with-v2-api/44780

@yarikoptic
Copy link
Member Author

yarikoptic commented Aug 23, 2022

so far it seems boils down to use v1.1 API for now

edit: and any possible questions could be cleared up with circleci discuss

@yarikoptic
Copy link
Member Author

there were answers on https://discuss.circleci.com/t/downloading-build-logs-with-v2-api/44780/3 . @jwodder - are they sufficient to get this feature implemented?

@jwodder
Copy link
Member

jwodder commented Dec 5, 2022

@yarikoptic Those told me nothing I didn't already know. The situation remains the same as before: logs can currently only be downloaded via the v1 API, which is slated for removal.

@yarikoptic
Copy link
Member Author

it seems that only 1 step requires v1 api , the others could be done via v2. So let's get it implemented via v2+v1 mix. It should be trivial to redo one step via v2 whenever time comes.

@yarikoptic
Copy link
Member Author

ping on this @jwodder -- one more project I would have loved to archive logs for is afni, in particular in the wakes of afni/afni#466 and alike so I could see when regressions happened etc.

yarikoptic added a commit that referenced this issue May 8, 2023
Support fetching logs & artifacts from CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants