-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detects AppleClang as Clang #159
Comments
I can confirm that I am also experiencing this issue in 0.14 |
@memsharded I tested with a simple CMakeLists.txt and the same issue appears:
|
Hi @mathiasi I think that this issue could be related to the https://cmake.org/cmake/help/latest/policy/CMP0025.html Could you try to set the policy to
Hope this helps. Please tell me if that fixes the issue |
@czoido Thanks, it appears to have fixed the invalid settings.compiler.version value - I'm still seeing the |
Hi @mathiasi I think that maybe CMake is no being able to find the MacOs SDK sysroot. Something like:
Hope this helps :) |
Hi @czoido Bingo! After setting SDKROOT the error no longer appears :) Closing this but I'm not sure if any changes is still needed for cmake-conan to handle this. |
It seems that the SDKROOT is a pure cmake OSX issue, that is, not related to conan, would you get the same even if not using conan? I think so. Cmake-conan is just a wrapper to call Conan with the right arguments, but those arguments do not have anything related to the SDK. I'd say we can leave this as closed. Thanks for all the feedback! |
I think I have to reopen this issue again. Upon further inspection this seems to be still an issue if used in conjunction with add_subdirectory in CMake. Consider this structure:
For testing I have set |
Hi @mathiasi |
Hi @czoido - Fantastic, that appears to have done the trick :) |
I had to use |
When I updated my Conan CMake file (which was old) and then I got the string error too. I did trace it back a couple of releases, but I don’t have the details on me :) |
Note that I didn’t have the compiler issue, just the string include error |
You can test it in the project below on Mac, just go back a couple of versions on the conan.cmake file (download from the website) and the string include error disappears. Note that it doesn’t seem to matter, things seem to work even if the error is printed. |
Hi @patricia-gallardo, |
I did not, because I didn’t have to before, the project works with a
previous version of the conan file.
…On Sat, 23 Nov 2019 at 09:42, Carlos Zoido ***@***.***> wrote:
Hi @patricia-gallardo <https://github.com/patricia-gallardo>,
I was not able to reproduce the issue with the project above. Did you set
the SDKROOT environment variable? The message is probably related to
this:
https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html#variable:CMAKE_OSX_SYSROOT
and not to Conan itself.
Hope this helps. Please let me know if the issue still happens.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#159?email_source=notifications&email_token=AGABXMI5H3B2NQAUUY3RYB3QVDUIRA5CNFSM4IFDPE32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7QSIA#issuecomment-557779232>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGABXMJI56AGNOSECAOILOTQVDUIRANCNFSM4IFDPE3Q>
.
|
Hi @patricia-gallardo,
Which macOS version are you using? |
|
Hi @sergeyklay, |
|
|
The problem is gone using https://github.com/conan-io/cmake-conan/raw/v0.13/conan.cmake (instead of v0.14) |
FYI:
|
Hi @sergeyklay, thanks a lot for all the information, It's being very useful to outline the issue. |
Status update. Setting cmake_policy(SET CMP0025 NEW) echo "::set-env name=SDKROOT::$(xcodebuild -version -sdk macosx Path)" Fixes the issue at GitHub Action. But note:
|
Sorry to intervene, but I believe I have something to add here. I hit that problem too with 0.15 and it looks like cmake is actually properly detects a path to SDK, but it doesn't set it in I'm trying to find the best way to perform this test without asking user to set additional environment variables. But I though that information might be useful and someone could do it faster than me. :) |
Issue #225 also relates to the |
This error should be fixed by: #226 to be merged in v0.16 |
Seems like this has been discussed before: #52 , #33
Even though they have been marked as resolved, it's still happening to me right now on version 0.14.
Let me know if you need other information and I will happily provide to resolve this issue! :)
The text was updated successfully, but these errors were encountered: