Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android compiler.libcxx #213

Open
pkubik opened this issue Mar 14, 2020 · 2 comments
Open

Add support for Android compiler.libcxx #213

pkubik opened this issue Mar 14, 2020 · 2 comments

Comments

@pkubik
Copy link

pkubik commented Mar 14, 2020

Right now the main scripts sets only one of the desktop specific values for the compiler.libcxx (in conan_cmake_detect_unix_libcxx macro), e.g. libstdc++, libstdc++11. Please add support for other types values, e.g. c++_staticandc++_shared`.
Since it would be difficult to fully handle all special cases like Android I'd suggest another parameter for the override. At the moment it's possible to specify custom settings, but they are appended to the settings generated by the script and thus ignored, e.g.:

Conan executing: /home/pkubik/.local/bin/conan install . -s build_type=Debug -s compiler=clang -s compiler.version=9 -s compiler.libcxx=libstdc++11 -s compiler.libcxx=c++_shared

Note that compiler.libcxx is given twice, and the second one (specified manually) is being ignored rendering me unable to choose the correct value for Android project.

@czoido
Copy link
Contributor

czoido commented Mar 30, 2020

Hi @pkubik,
I have reproduced the issue, you are right that those settings will not be taken into account.
Thanks a lot for reporting this, we'll have a look at it.

@czoido czoido added this to the 0.16 milestone Mar 30, 2020
@czoido
Copy link
Contributor

czoido commented Jul 10, 2020

Hi @pkubik,
This issue is related to #255 and will be fixed by #258 that will be merged to 0.16 version. Now compiler.libcxx will be set correctly.

@czoido czoido removed this from the 0.16 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants