Remove manually specified settings from auto list #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
changed the title
smessmer
added a commit
to cryfs/cryfs
that referenced
this pull request
Jul 1, 2020
…b4e22b3ae4): Make "SETTINGS compiler.libcxx=libstdc++11" do the right thing (see conan-io/cmake-conan#255)
memsharded
approved these changes
Sep 1, 2020
| @@ -229,6 +229,13 @@ function(conan_cmake_settings result) | |||
| compiler.runtime compiler.libcxx compiler.toolset) | |||
| endif() | |||
|
|
|||
| # remove any manually specified settings from the autodetected settings | |||
| foreach(ARG ${ARGUMENTS_SETTINGS}) | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual settings were added in the end to automatic CMake settings, so they were not taken into account because only the first one was considered by CMake.
This PR removes the MANUAL settings from the AUTO list of added settings from CMake so that they are not added twice.
Fixes: #255