add missing = in profile command line argument
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this `=` after `-pr` enables the PROFILE passed to conan_cmake_run to be used. Previously (at least on my Windows test machine), the PROFILE was not taken into account and conan was running with the default profile. Now the profile used is the correct one.
|
|
|
Thanks for fixing this! Will be in next 0.15 release. |
wawa19933
pushed a commit
to wawa19933/cmake-conan
that referenced
this pull request
Mar 19, 2020
add missing `=` in profile command line argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this
=after-prenables the PROFILE passed to conan_cmake_run to be used. Previously (at least on my Windows test machine), the PROFILE was not taken into account and conan was running with the default profile. Now the profile used is the correct one.Note: this makes the treatment of the
-prargument consistent with other conan.cmake-injected arguments such as-gor--build, which both have an=sign.