Add additional compiler options to conan_cmake_detect_unix_libcxx #197
Conversation
Without these many options many wrappers (e.g. ccache, winegcc) or cross-compiling toolchains (e.g. yocto) may not find the intended underlying tools and sysroot, leading to the command failing, or (perhaps worse) succeeding, but using defaults instead of the intended underlying gcc or libstdc++ and thus getting inaccurate results
puetzk
force-pushed
the
conan_cmake_detect_unix_libcxx-args
branch
from
e70c3e2 to
5d2d01d
Compare
|
one Travis failure (xcode8.3), but seems to be a network error hitting bintray, which seems unrelated to my changes: https://travis-ci.org/conan-io/cmake-conan/jobs/641220956#L2958-L2961
I don't see a way to ask it to rerun; presumably that takes more permissions. |
|
Hi @puetzk, I closed and opened to relaunch the CI |
|
Thanks. I've got the CLA submitted to our OSS governance contribution review;; I don't expect any problem since they've approved contributions in other Conan repositories with the same wording, but it's apparently taking a few days. |
|
CLA finally signed, sorry that took much longer than usual this time for some reason. |
…IONS Both of these CMake properties permit generator-expressions, but execute_process runs at configuration time and so won't expand them, and the compiler will not accept $<...> syntax verbatim. I see no way to get them expanded properly while still running this during configuration, but it seems reasonable to assume that conditional options should not change something as fundamental as settings.libcxx
…etect_unix_libcxx-args
puetzk
force-pushed
the
conan_cmake_detect_unix_libcxx-args
branch
from
5d2d01d to
802a932
Compare
|
|
|
Related issue that might touch on these changes: #256 |
Without these many options many wrappers (e.g. ccache, winegcc) or cross-compiling toolchains (e.g. yocto) may not find the intended underlying tools and sysroot, leading to the command failing, or (perhaps worse) succeeding, but using defaults instead of the intended underlying gcc or libstdc++ and thus getting inaccurate results.
Fixes #182
Fixes #195