Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parse_arguments name #211

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Change parse_arguments name #211

merged 1 commit into from
Jul 13, 2020

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Mar 12, 2020

Change parse_arguments to conan_parse_arguments to avoid user's functions collision.
Fixes: #210

tjwrona
tjwrona approved these changes Mar 19, 2020
View reviewed changes
Copy link

@tjwrona tjwrona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, not sure if I have the official authority to "approve" or not haha

@czoido czoido added this to the 0.16 milestone Mar 30, 2020
@czoido czoido closed this Jul 10, 2020
@czoido czoido reopened this Jul 10, 2020
@czoido czoido requested a review from jgsogo July 10, 2020 08:01
@czoido czoido merged commit 65c9d18 into conan-io:develop Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwrona tjwrona tjwrona approved these changes

@jgsogo jgsogo jgsogo approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.

"parse_arguments" macro should have a more specific name
3 participants
@czoido @jgsogo @tjwrona