Add VERIFY_SSL arg to conan_add_remote #228
Conversation
|
|
There was a problem hiding this comment.
Hi @gordonread
It seems there is something wrong in this contribution. Possibly adding a test would have raised this error, could you please try to add such test?
Many thanks! (and sorry this took a while to review)
| ${CONAN_INDEX_ARG} -f) | ||
| set(CONAN_VERIFY_SSL_ARG "True") | ||
| if(DEFINED CONAN_VERIFY_SSL) | ||
| set(CONAN_VERIFY_SSL_ARG ${CONAN_VERIFY_SSL}) |
There was a problem hiding this comment.
It seems this is missing the --verify-ssl argument. In the same way the CONAN_INDEX_ARG introduces the -i ... argument, this will need this (note the other args as NAME, URL are positional instead)
There was a problem hiding this comment.
Thanks for looking at this, for me, conan reports:
usage: conan remote add [-h] [-i [INSERT]] [-f] remote url [verify_ssl]
conan remote add: error: the following arguments are required: remote, url
ERROR: Exiting with code: 2
so this change simply sets ${CONAN_VERIFY_SSL_ARG} to either True or whatever the VERIFY_SSL parameter is set to if it's there, this value is then put on the end of the command (below) as per the help above - I can't see any mention of a --verify-ssl in the conan docs that I have.
Please correct me if I'm wrong.
I'll add a test as requested in your email though.
/Gordon
There was a problem hiding this comment.
I think this should be ok, now the verify_ssl argument for conan remote add is positional: https://github.com/conan-io/conan/blob/29b04421a650560673db9e41a9d62060bda3dc90/conans/client/command.py#L1509-L1510
@gordonread I'm adding a test to check the changes and also updating the docs
…RIFY_SSL-arg-to-conan-add-remote
This adds a VERIFY_SSL argument to the conan_add_remote function (We have a local conan repository that requires the verify ssl argument be false)