Quote variables in conan_cmake_detect_vs_runtime #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for the possibility that variables are empty, or have values which are themselves variable names, in conan_cmake_detect_vs_runtime.
There are two issues this quoting resolves. One is errors resulting from empty variables - for exampe, if `CMAKE_CXX_FLAGS` is empty, the `string` call would have failed because it would have appeared to have too few arguments - quoting the final argument fixes this.
The other is that in the context of `if`, a lot of operators try to resolve their argument as a variable name first (but only if it's unquoted), meaning that `if(${build_type} STREQUAL "DEBUG")` would have unexpected results if `build_type` is set to `DEBUG` and there is a variable `DEBUG` set to `YES`, say. Quoting the variable expansion prevents this behaviour.
|
|
|
Resurrecting - there were initially some CLA issues, but they're all resolved now and I can confirm that this code is covered by the CLA. |
danimtb
approved these changes
Sep 1, 2020
|
Thanks for your contribution! (and sorry for the delay in reviewing it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for the possibility that variables are empty, or have values which are themselves variable names, in conan_cmake_detect_vs_runtime.
There are two issues this quoting resolves. One is errors resulting from empty variables - for exampe, if
CMAKE_CXX_FLAGSis empty, thestringcall would have failed because it would have appeared to have too few arguments - quoting the final argument fixes this.The other is that in the context of
if, a lot of operators try to resolve their argument as a variable name first (but only if it's unquoted), meaning thatif(${build_type} STREQUAL "DEBUG")would have unexpected results ifbuild_typeis set toDEBUGand there is a variableDEBUGset toYES, say. Quoting the variable expansion prevents this behaviour.