-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate conan install from autodetection #310
Merged
czoido
merged 28 commits into
conan-io:develop
from
czoido:refactor/decouple_autodetection
Feb 23, 2021
Merged
Separate conan install from autodetection #310
czoido
merged 28 commits into
conan-io:develop
from
czoido:refactor/decouple_autodetection
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Feb 22, 2021
|
||
message(STATUS "Conan: Automatic detection of conan settings from cmake") | ||
|
||
macro(_conan_detect_build_type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try to use functions with returns, instead of macros.
…or/decouple_autodetection
…or/decouple_autodetection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Conan is adding more arguments to support new features as lockfiles or build and host profiles, this features usually collide with the cmake-conan settings auto-detection. This PR adds some functions to decouple the auto-deteccion from the call to
conan install
so instead of just calling toconan_cmake_run
, these functions can be called separately (conan_cmake_run
is still there but is recommended to use just for basic cases, not for using new Conan features):conan_cmake_configure
conan_cmake_autodetect
conan_cmake_install
all the input arguments fromconan install
are mapped to this cmake function.A CMakeLists.txt using these functions would look like this:
or including conanbuildinfo.cmake
This PR some refactors from the previous state.
Closes: