Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add OUTPUT_FOLDER to conan install #403

Merged
merged 9 commits into from
Mar 24, 2022

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Mar 23, 2022

Add --output-folder to conan install.

Ignore whitespace changes (stripped whitespace at the end.)

Thanks for merging.

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2022

CLA assistant check
All committers have signed the CLA.

@gabyx gabyx force-pushed the bugfix/add-output-folder-argument branch from 67074e1 to 5984be6 Compare March 23, 2022 17:13
@gabyx gabyx changed the base branch from master to develop March 24, 2022 07:32
@czoido czoido added this to the 0.18 milestone Mar 24, 2022
@czoido
Copy link
Contributor

czoido commented Mar 24, 2022

Hi @gabyx,
Thanks a lot for the contribution, could you please add a test for this?

@gabyx
Copy link
Contributor Author

gabyx commented Mar 24, 2022

@czoido: I could but I am a bit afraid without any docker setup to execute locally, does that test.py work :).

@czoido
Copy link
Contributor

czoido commented Mar 24, 2022

@czoido: I could but I am a bit afraid without any docker setup to execute locally, does that test.py work :).

Don't worry, I'll try to add some basic tests :)

@czoido czoido self-assigned this Mar 24, 2022
@czoido czoido merged commit 3530ac4 into conan-io:develop Mar 24, 2022
@czoido
Copy link
Contributor

czoido commented Mar 24, 2022

Merged, @gabyx thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants