Search conan executable in the default installer location #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official Windows installer [1] by default installs conan to `%ProgramFiles%\Conan\conan\conan.exe`. Add this subdirectory to the find_package call on Windows. [1] - https://conan.io/downloads
|
|
memsharded
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Thanks for your contribution @nolange
It is not fully clear why this would be necessary. The Windows installer puts Conan in the path, so it should be found by find_program without further issues.
|
no, putting stuff in path is a really bad idea, windows will search DLLs there. if you dont have conan in path, the script wont work obviously |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official Windows installer [1] by default installs conan to
%ProgramFiles%\Conan\conan\conan.exe.Add this subdirectory to the find_package call on Windows.
[1] - https://conan.io/downloads