Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set compiler.cstd in host profile #664

Open
wants to merge 1 commit into
base: develop2
Choose a base branch
from
Open

Conversation

jhol
Copy link
Contributor

@jhol jhol commented Aug 13, 2024

The cstd setting was added to Conan in v2.4.0. Similar to cppstd, it is used to indicate the selected C language standard.

The branch of this PR is based upon the tidy-ups branch from #656, which has not yet been merged to develop2, hence why the additional patches are also visible.

The cstd setting was added to Conan in v2.4.0. Similar to cppstd, it is
used to indicate the selected C language standard.
@jhol
Copy link
Contributor Author

jhol commented Dec 19, 2024

@valgur @memsharded would it be possible to get this merged?

@memsharded
Copy link
Member

Hi @jhol

Thanks for your PR and sorry it was not reviewed back then.

The problem with this PR is that it creates a profile that is not aligned with the default Conan profiles.
conan profile detect will not define the cstd yet, at the moment it is considered an opt-in as it can change some things, effect the package_id, etc, so it is a bit risky to be defined by default.

I am not fully opposed to it, but we need to carefully consider this, I'll try to review it with @jcar87 when possible, thanks for the ping!

@jhol
Copy link
Contributor Author

jhol commented Dec 20, 2024

The problem with this PR is that it creates a profile that is not aligned with the default Conan profiles.
conan profile detect will not define the cstd yet, at the moment it is considered an opt-in as it can change some things, effect the package_id, etc, so it is a bit risky to be defined by default.

Is there a way we can make this opt-in or opt-out in conan_provider.cmake? This is necessary in my project so that the correct cstd can be passed through to conan recipes for cmake-powered projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants