Skip to content

Commit

Permalink
poppler: drop v21.07.0
Browse files Browse the repository at this point in the history
  • Loading branch information
valgur committed Nov 16, 2023
1 parent 258f12f commit 87039e6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 26 deletions.
7 changes: 0 additions & 7 deletions recipes/poppler/all/conandata.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,7 @@ sources:
"23.11.0":
url: "https://poppler.freedesktop.org/poppler-23.11.0.tar.xz"
sha256: "f99cca6799cb9cb6c92fc1e0eb78547b611cb733750ab7cb047cb0e6c246539c"
"21.07.0":
url: "https://poppler.freedesktop.org/poppler-21.07.0.tar.xz"
sha256: "e26ab29f68065de4d6562f0a3e2b5435a83ca92be573b99a1c81998fa286a4d4"
patches:
"23.11.0":
- patch_file: "patches/23/0004-add-POPPLER_DATADIR-environment-variable.patch"

Check warning on line 7 in recipes/poppler/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/23/0004- ... ^ (line: 7)
- patch_file: "patches/23/0007-cmake-use_conan_qt.patch"

Check warning on line 8 in recipes/poppler/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

Schema outlined in https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields is not followed. required key(s) 'patch_description', 'patch_type' not found in - patch_file: patches/23/0007- ... ^ (line: 8)
"21.07.0":
- patch_file: "patches/21/0004-add-POPPLER_DATADIR-environment-variable.patch"
- patch_file: "patches/21/0005-fix-visual-studio-basetsd.h-libjpeg-INT32.patch"
- patch_file: "patches/21/0007-cmake-use_conan_qt.patch"
20 changes: 3 additions & 17 deletions recipes/poppler/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,10 @@ class PopplerConan(ConanFile):

@property
def _cppstd_required(self):
if Version(self.version) > "21.11" or (self.options.with_qt and Version(self.dependencies["qt"].ref.version).major == "6"):
return 17
else:
return 14
return 17

@property
def _minimum_compilers_version(self):
if self._cppstd_required == 14:
return {
"Visual Studio": "15",
"msvc": "191",
"gcc": "5",
"clang": "5",
"apple-clang": "5.1",
}
return {
"Visual Studio": "16",
"msvc": "192",
Expand Down Expand Up @@ -160,18 +149,15 @@ def validate(self):
check_min_cppstd(self, 14)

minimum_version = self._minimum_compilers_version.get(str(self.settings.compiler), False)
if not minimum_version:
self.output.warning("C++14 support required. Your compiler is unknown. Assuming it supports C++14.")
elif Version(self.settings.compiler.version) < minimum_version:
if minimum_version and Version(self.settings.compiler.version) < minimum_version:
raise ConanInvalidConfiguration("C++14 support required, which your compiler does not support.")

def build_requirements(self):
if not self.conf.get("tools.gnu:pkg_config", default=False, check_type=str):
self.tool_requires("pkgconf/2.0.3")
if self.options.get_safe("with_glib"):
self.tool_requires("glib/<host_version>")
if Version(self.version) > "22.12.0":
self.tool_requires("cmake/[>=3.16 <4]")
self.tool_requires("cmake/[>=3.16 <4]")

def source(self):
get(self, **self.conan_data["sources"][self.version], strip_root=True)
Expand Down
3 changes: 1 addition & 2 deletions recipes/poppler/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
versions:
"23.11.0":
folder: all
"21.07.0":
folder: all

Check failure on line 4 in recipes/poppler/config.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

too many blank lines

0 comments on commit 87039e6

Please sign in to comment.