Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[request] wxWidgets/3.2.1 #20092

Open
hweemiin opened this issue Sep 24, 2023 · 10 comments
Open

[request] wxWidgets/3.2.1 #20092

hweemiin opened this issue Sep 24, 2023 · 10 comments
Labels
upstream update

Comments

@hweemiin
Copy link

Package Name/Version

wxwidgets/3.2.1

Changelog

https://raw.githubusercontent.com/wxWidgets/wxWidgets/v3.2.1/docs/changes.txt

Context about the new update

The above-mentioned version is newly released by the upstream project and not yet available as a recipe.
Please add this version.
@hweemiin hweemiin mentioned this issue Sep 24, 2023
Closed
@samuel-emrys
Copy link
Contributor

samuel-emrys commented Sep 24, 2023 •
edited
Loading

@hweemiin is there a reason you've raised your PR for bincrafters instead of CCI? I'm sure there's desire to have wxwidgets available in CCI - #19991, #5190, #621

@hweemiin
Copy link
Author

hmm, I found previous wxWidgets recipe on bincrafters first, then I click on the link of "Request new package" on bincrafters page and it send me to CCI. Not sure what's the relationship between the two, is bincrafters obsolete and being replaced by CCI?

@samuel-emrys
Copy link
Contributor

I'm not sure what the current state of bincrafters is, but it's only had 1 commit in the past 2 years. Maybe @Croydon can provide some context here.

My understanding is that it hosts recipes that can't be hosted on CCI for whatever reason. It looks like the reasons it hasn't been on CCI historically may be largely resolved given that many of the system dependencies for wxwidgets appear to now be available as cci recipes

@luizfeldmann
Copy link
Contributor

Linking the recipe from Bincrafters.

This is a convenient place to see what are the dependencies.

@luizfeldmann luizfeldmann mentioned this issue Oct 28, 2023
Open
@samuel-emrys
Copy link
Contributor

samuel-emrys commented Oct 28, 2023 •
edited
Loading

Linking the recipe from Bincrafters

This is an old/deprecated recipe. The current recipe is here https://github.com/bincrafters/community/blob/main/recipes/wxwidgets/all/conanfile.py

The PR relating to this issue is bincrafters/community#1453

Suggest this issue be moved to bincrafters as not relevant to cci

@luizfeldmann
Copy link
Contributor

Can CCI 'steal' working recipes from there ?

@samuel-emrys
Copy link
Contributor

Can CCI 'steal' working recipes from there ?

The bincrafters recipes appear to be MIT licensed, so I don't see any problems using those as a base to build a CCI recipe on, however, as above:

My understanding is that it [bincrafters] hosts recipes that can't be hosted on CCI for whatever reason. It looks like the reasons it hasn't been on CCI historically may be largely resolved given that many of the system dependencies for wxwidgets appear to now be available as cci recipes

So it's not obvious to me that they would be suitable out of the box.

@uilianries
Copy link
Member

Can CCI 'steal' working recipes from there ?

Yes. Bincrafters is under MIT license. (I'm one of Bincrafters' maintainers too)

My understanding is that it hosts recipes that can't be hosted on CCI for whatever reason. bincrafters/community#1441 (comment) given that many of the system dependencies for wxwidgets appear to now be available as cci recipes

True. The main project that was not acceptable in CCI, but want in Bincrafters is the modular boost, where each boost project is a Conan package. It would required a prepared CI only for it, to solve the graph, rebuild everything ... something not inclined to be accepted here.

gmeeker added a commit to gmeeker/conan-center-index that referenced this issue Nov 24, 2023
@gmeeker
(conan-io#5190) (conan-io#19991) (conan-io#20092) new wxwidgets recip…
6eef040 
…e; ported from bincrafters to v2
gmeeker added a commit to gmeeker/conan-center-index that referenced this issue Nov 24, 2023
@gmeeker
(conan-io#5190) (conan-io#19991) (conan-io#20092) new wxwidgets recip…
2e7741e 
…e; ported from bincrafters to v2
gmeeker added a commit to gmeeker/conan-center-index that referenced this issue Nov 24, 2023
@gmeeker
(conan-io#5190) (conan-io#19991) (conan-io#20092) new wxwidgets recip…
bb41a51 
…e; ported from bincrafters to v2
@gmeeker gmeeker mentioned this issue Nov 24, 2023
Merged
3 tasks
Werni2A pushed a commit to Werni2A/conan-center-index that referenced this issue Jan 20, 2024
@gmeeker @Werni2A
(conan-io#5190) (conan-io#19991) (conan-io#20092) new wxwidgets recip…
a174237 
…e; ported from bincrafters to v2
@hweemiin hweemiin mentioned this issue Jan 28, 2024
Closed
3 tasks
@herring-swe
Copy link

herring-swe commented May 23, 2024 •
edited
Loading

I made a 3.2.3 package for conan 2 a while ago which works on Windows and Linux.
Actually tested today on conan v1 (1.62) and it works there as well.
It's based on bincrafters 3.1.5 recipe but heavily modified so it finds built libraries via cmake installed config files and expose them as components,.
Maybe something of that can be merged into your recipe @gmeeker.

https://github.com/herring-swe/conan/blob/main/recipes/wxwidgets/3.2.3/conanfile.py

conan-center-bot pushed a commit that referenced this issue Aug 19, 2024
@gmeeker @memsharded
@czoido @valgur
(#21353) wxWidgets intial recipe
e18fb92 
* (#5190) (#19991) (#20092) new wxwidgets recipe; ported from bincrafters to v2

* [wxwidgets] use f-strings

* [wxwidgets] remove glib override

* [wxwidgets] Add gtk option and default to gtk/system for now.

* [wxwidgets] update system_requirements

* [wxwidgets] Adding 3.2.4

* [wxwidgets] fix errors from gtk and opengl options

* [wxwidgets] default to GTK2 to match gtk/system binaries in CCI

* [wxwidgets] fix fPIC handling

* [wxwidgets] fix nanosvg usage

* [wxwidgets] fix cmake dependencies

* [wxwidgets] don't package cmake files

* [wxwidgets] fix macOS patching

* [wxwidgets] use is_msvc

* [wxwidgets] removing 3.1.x versions

* [wxwidgets] Adding libraries to cpp_info to fix hook warnings.

* remove older versions, add version ranges

* fix config.yml for wxwidgets

* add version range for expat

* Update recipes/wxwidgets/all/conanfile.py

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

* [wxwidgets] set gtk, xkbcommon options

* simplify recipe options

* wip

* simplify

* remove comment

* put jpeg option back

---------

Co-authored-by: memsharded <james@conan.io>
Co-authored-by: czoido <mrgalleta@gmail.com>
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
@Croydon
Copy link
Contributor

Croydon commented Oct 2, 2024

Done by #21353

@Croydon Croydon mentioned this issue Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Croydon @uilianries @herring-swe @hweemiin @samuel-emrys @luizfeldmann