-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageMagick: Add 7.1.0-29 and build it with cmake on all platforms. #10003
Conversation
This fixes the previously broken Windows build and adds a bunch of new possible dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI didn't detect changes here, we need to investigate it.
cc/ @uilianries @danimtb
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sorry for being slow on this, how do you usually handle missing prebuilts? |
@Cyriuz I gonna check will cairo is missing and try to regenerate it. THanks for reporting. |
This comment has been minimized.
This comment has been minimized.
@uilianries Did you get a chance to look into this? I could disable these deps by default I guess but maybe that is the wrong way to handle it :) |
@Cyriuz yes, I tried to regenerate both cairo and pango multiple times, but that same package id is always missing. I'll investigate further tomorrow, thank you for pinging! |
Hi! Here the issue (at least one of them) with
We just need to upgrade |
@jgsogo thank you very much!! |
… into imagemagick-cmake
I detected other pull requests that are modifying imagemagick/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Failure in build 15 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Sorry for being so slow with this and thanks for pointing out the issue. I wanted to try to bump pango but got hit by the linter now, I had hoped I wouldn't need to change the 7.0 recipe since it doesn't build on my Windows dev env but maybe its unavoidable? Not sure if it is worth fixing this PR since we now have #12371? This one makes the recipe super easy but it depends on my cmake patch which I had hoped would be adopted by imagemagick, but that might be wishful thinking since I have had so little time to spend on this lately. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
This fixes the previously broken Windows build and adds a bunch of new possible dependencies.
Specify library name and version: imagemagick/7.1.0-29
I was a bit sad when I realized that the current ImageMagick package in conan-center did not support Windows and after looking around a bit for solutions I found some previous discussions about its build scripts being very complicated for Windows and some attempts at contributing a CMake build script instead (here and here). So I continued the work on the CMake scripts to make it work with the latest release and on windows/linux/mac. The patch provided in this PR is based on my fork here.
The maintainers of ImageMagick have stated an interest in a CMake build script but would like some more people to test and use it before adapting it as stated here. So I thought this would be a good way to get it used even if it is not merged to ImageMagick itself yet, as the CMake build script simplifies the build by miles.
conan-center hook activated.