Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#10919) libcurl: Expose control to --with_ca_bundle and --with_ca_path #10922

Merged
merged 1 commit into from
May 30, 2022

Conversation

chenpengfei
Copy link
Contributor

@chenpengfei chenpengfei commented May 24, 2022

We needed a way to expose control of the --with_ca_bundle and --with_ca_path libcurl option to the users of this recipe.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented May 24, 2022

I detected other pull requests that are modifying libcurl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@uilianries
Copy link
Member

Not sure, but those options are related to runtime, which we can not guarantee when building any package. I don't think it's a valid option to be exposed if we can not hardcode any path.

Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth providing these options, if upstream provides them.
yes, in general, CI paths might not be the same as user's paths, but it's something you control.

@conan-center-bot
Copy link
Collaborator

All green in build 5 (e33b1c907fd4186d407c7138a4dae4de6218f43f):

  • libcurl/7.83.0@:
    All packages built successfully! (All logs)

  • libcurl/7.64.1@:
    All packages built successfully! (All logs)

  • libcurl/7.83.1@:
    All packages built successfully! (All logs)

  • libcurl/7.82.0@:
    All packages built successfully! (All logs)

  • libcurl/7.79.0@:
    All packages built successfully! (All logs)

  • libcurl/7.75.0@:
    All packages built successfully! (All logs)

  • libcurl/7.80.0@:
    All packages built successfully! (All logs)

  • libcurl/7.79.1@:
    All packages built successfully! (All logs)

  • libcurl/7.78.0@:
    All packages built successfully! (All logs)

  • libcurl/7.77.0@:
    All packages built successfully! (All logs)

  • libcurl/7.73.0@:
    All packages built successfully! (All logs)

  • libcurl/7.76.0@:
    All packages built successfully! (All logs)

  • libcurl/7.74.0@:
    All packages built successfully! (All logs)

  • libcurl/7.71.0@:
    All packages built successfully! (All logs)

  • libcurl/7.68.0@:
    All packages built successfully! (All logs)

  • libcurl/7.67.0@:
    All packages built successfully! (All logs)

  • libcurl/7.66.0@:
    All packages built successfully! (All logs)

  • libcurl/7.70.0@:
    All packages built successfully! (All logs)

  • libcurl/7.72.0@:
    All packages built successfully! (All logs)

  • libcurl/7.69.1@:
    All packages built successfully! (All logs)

  • libcurl/7.71.1@:
    All packages built successfully! (All logs)

@ghost ghost mentioned this pull request May 30, 2022
4 tasks
@conan-center-bot conan-center-bot requested a review from jgsogo May 30, 2022 12:00
@conan-center-bot conan-center-bot merged commit ab48b84 into conan-io:master May 30, 2022
@zhoupeng6d
Copy link

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants