-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modern-cpp-kafka: new recipe #11430
modern-cpp-kafka: new recipe #11430
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@kenneth-jia Unfortunately, the recipe you wrote must have test_package folder. |
e08d25e
to
e113acd
Compare
This comment has been minimized.
This comment has been minimized.
e113acd
to
2104ddd
Compare
This comment has been minimized.
This comment has been minimized.
Just added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution
2104ddd
to
eed689c
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a small detail
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just need to wait for user approval.
Thank you a lot for the help, @uilianries! 😀 |
@kenneth-jia No, thank you for contributing! 💚 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c8674cf
to
f02663c
Compare
This comment has been minimized.
This comment has been minimized.
f02663c
to
4fdd7a5
Compare
6df4ae8
to
ade4972
Compare
This comment has been minimized.
This comment has been minimized.
ade4972
to
1396f74
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
All green in build 27 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Let me explain the logic with v2 migration and those test folders:
- every recipe should have a
test_package
, it is the default name that Conan will look for. - recipes in CCI can have several
test_xxxx
folders, and the CI here will execute all of them. Why? Sometimes it is useful to write several tests to check the names for different generators. - if for some reason, there is a test we want to keep and it can only run with Conan v1 (for example, we want to keep testing
cmake_find_package
), then the folder should be namedtest_v1_xxxx
, i.e.: https://github.com/conan-io/conan-center-index/tree/master/recipes/fmt/all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: modern-cpp-kafka/v2022.06.15
Hi,
I'm the author of
modern-cpp-kafka
(https://github.com/morganstanley/modern-cpp-kafka), a Kafka C++ API, wrapper overlibrdkafka
).Now I'm trying to add this header-only library to the ConanCenter (morganstanley/modern-cpp-kafka#105)
Thanks!