Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abseil: cross-compatibility conan v1/v2 #12056

Merged
merged 8 commits into from
Aug 26, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Aug 4, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Aug 4, 2022

I detected other pull requests that are modifying abseil/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Aug 4, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 4, 2022

ERROR: abseil/20200923.3 (test package): Error in build() method, line 12
	cmake.definitions["CXX20_SUPPORTED"] = tools.Version(self.deps_cpp_info["abseil"].version) > "20210324.2"
	ConanException: Invalid version 'None'

Why is it not valid in test_v1_package? I've kept the same conanfile 😲 , and I see recent PR of abseil where this previous test_package is working fine.

/cc @jgsogo @czoido

@jgsogo
Copy link
Contributor

jgsogo commented Aug 4, 2022

We have just upgraded to Conan 1.50.1 this afternoon. Maybe a regression?

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 4, 2022

I guess, I can reproduce this issue locally with conan create . abseil/20211102.0@ -tf test_v1_package. Maybe a breaking change where self.deps_cpp_info values are unkown in build() but not in generate()?

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 10, 2022

I guess, I can reproduce this issue locally with conan create . abseil/20211102.0@ -tf test_v1_package. Maybe a breaking change where self.deps_cpp_info values are unkown in build() but not in generate()?

Fixed in conan 1.51.1 by conan-io/conan#11790. So waiting an update of conan version in CCI.

@ghost ghost mentioned this pull request Aug 12, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Aug 23, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 6 (8b73adcb3951f165bd51702796b65e386e0db456):

  • abseil/20220623.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    
  • abseil/20200923.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    
  • abseil/20210324.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    
  • abseil/20200225.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    
  • abseil/20211102.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12056/recipes/abseil/all/conanfile.py", line 3, in <module>
        from conan.tools.apple import is_apple_os
    ImportError: cannot import name 'is_apple_os' from 'conan.tools.apple' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conan/tools/apple/__init__.py)
    

@conan-center-bot conan-center-bot merged commit d68421f into conan-io:master Aug 26, 2022
@SpaceIm SpaceIm deleted the abseil-conan-v2 branch August 26, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants