[boost] Fix scm.Version usage #12119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
ghost
mentioned this pull request
|
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Aug 9, 2022
|
Can you please modify |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Done. |
jgsogo
approved these changes
Aug 9, 2022
|
All green in build 2 (
|
Hooks produced the following warnings for commit ce9dd5fboost/1.71.0boost/1.70.0boost/1.73.0boost/1.72.0boost/1.75.0boost/1.74.0boost/1.77.0boost/1.79.0boost/1.78.0boost/1.76.0 |
jgsogo
approved these changes
Aug 10, 2022
SSE4
approved these changes
Aug 10, 2022
lasote
reviewed
Aug 10, 2022
| @@ -1345,7 +1345,7 @@ def _toolset_tag(self): | |||
| if self._is_msvc: | |||
| toolset_version = self._toolset_version.replace(".", "") | |||
| else: | |||
| toolset_version = str(Version(self.settings.compiler.version).major) | |||
| toolset_version = str(Version(self.settings.compiler.version).major(fill=False)) | |||
There was a problem hiding this comment.
@uilianries please note that this is going to break again in next release because of conan-io/conan#11823
We don't have a universal fix right now
There was a problem hiding this comment.
@lasote , what works from 1.50 (current release in CCI) to 1.52 and 2.x? This is something we can add to the linter asap so we prevent changing recipes now and afterward again. This is the kind of change/fix that will probably spread to other recipes.
Thanks!
There was a problem hiding this comment.
Could we implement dummy fill args for conan.tools.scm.Version properties?
Otherwise seems like we'd have to set required_conan_version = ">=1.52.0" here which would be pretty bad.
There was a problem hiding this comment.
vale, I gonna open a new PR to avoid it.
There was a problem hiding this comment.
@uilianries , please, open a PR reverting (?) the changes, but please mention and wait for @lasote or @jcar87 to say something about a possible working syntax. Thanks!
There was a problem hiding this comment.
@jgsogo doing in 3..2..1
There was a problem hiding this comment.
Done, new PR available: #12131
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: boost/1.79.0
The new
scm.Versionno longer parsessemver, it only splits the version string.fixes #12044
/cc @markferry