libcap/2.65 + conan v2 compatibility #12241

bobrofon · 2022-08-15T20:09:10Z

Specify library name and version: libcap/2.65

libcap was updated to the latest release. And a few warnings from conan-center hooks were fixed.
Also, as I see it, there is ongoing refactoring in the repo. A lot of packages were rewritten to be compatible with conan v2. So I did a little refactoring of the recipe too (have a few concerns though).

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

WARN: [INVALID TOPICS (KB-H064)] The topic 'conan' is invalid and should be removed from topics attribute.

WARN: [TOOLS CROSS BUILDING (KB-H062)] The 'tools.cross_building(self.settings)' syntax may not work correctly in some scenarios. Consider using tools.cross_building(self).

libcap natively supports .pc files. And a minimal test package should check that at least the pkg_config generator works correctly (because this is how other packages typically work with libcap).

bobrofon · 2022-08-15T22:06:36Z

recipes/libcap/all/conanfile.py


    def package_info(self):
+        self.cpp_info.components["cap"].set_property("pkg_config_name",


When I'm trying to build a test package with this line, I get a warning: "(test package): WARN: [libcap/2.65] The PC package name libcap.pc already exists and it matches with another component one. Please, review all the component's pkg_config_name defined. Skipping it!". But I don't know how to figure out what's wrong here.

It's because there's a global one by default for v1 generators.

You need to set a root level one like AFAIK (not an expert just say that in another PR I reviewed recently)

self.cpp_info.set_property("pkg_config_name", "libcap-all-do-not-use")

bobrofon · 2022-08-15T22:13:35Z

recipes/libcap/all/test_package/conanfile.py

+
+    def generate(self):
+        env = Environment()
+        env.prepend_path("PKG_CONFIG_PATH", self.generators_folder)


For some reason, pkg_check_modules tries to find .pc files not in the generator_folder, but in the generator_folder/lib/pkgconfig. I thought the PkgConfigDeps generator should resolve that (via env vars maybe), but it doesn't. Not sure if I am doing something wrong or if it is a bug. I didn't find any examples of using CMakeToolchain and PkgConfigDeps generators together.

👋 @franramirez688 @czoido is this the right way to use CMakeToolchain and PkgConfigDeps generators together?

For some reason, pkg_check_modules tries to find .pc files not in the generator_folder, but in the generator_folder/lib/pkgconfig.

After digging deeper into it, I figured out that CMake is adding the suffix lib/pkgconfig to the CMAKE_PREFIX_PATH (pointing to the package_folder where the *.pc files are created). You can have a look at the issue https://gitlab.kitware.com/cmake/cmake/-/issues/18150

I thought the PkgConfigDeps generator should resolve that (via env vars maybe), but it doesn't

Yes, you're right, but it should not be necessary as far as CMake should use that CMAKE_PREFIX_PATH by default. As I said above, CMake is adding that suffix, so it's getting failed because there are no PC files there.

is this the right way to use CMakeToolchain and PkgConfigDeps generators together?

Given that information, I tend to say that yes, it could be one way to solve that issue, and I think there could be another workaround like:

def build(self): pkg_lib_folder = os.path.join(self.generators_folder, "lib", "pkgconfig") copy(self, "*.pc", self.generators_folder, pkg_lib_folder) cmake = CMake(self) cmake.configure() cmake.build()

Anyway, we could discuss if it could be a chance to create a mechanism to add the PKG_CONFIG_PATH via CMake build helper or even CMakeToolchain to avoid those workarounds.

SpaceIm · 2022-08-15T23:11:14Z

recipes/libcap/all/conanfile.py


-required_conan_version = ">=1.33.0"
+required_conan_version = ">=1.37.0"


Suggested change

required_conan_version = ">=1.37.0"

required_conan_version = ">=1.47.0"

SpaceIm · 2022-08-15T23:11:25Z

recipes/libcap/all/conanfile.py

@@ -26,82 +30,81 @@ class LibcapConan(ConanFile):
        "psx_syscals": False,
    }
    exports_sources = "patches/**"
+    generators = "VirtualBuildEnv", "VirtualRunEnv"


Hm, I was sure that the migrating guide recommends adding them, because they are enabled by default in v2. But I checked it, and it looks like I just mixed it up.
I will delete it.

SpaceIm · 2022-08-15T23:11:36Z

recipes/libcap/all/conanfile.py

+    def validate(self):
+        if self.info.settings.os != "Linux":
+            raise ConanInvalidConfiguration("Only Linux supported")


after configure please

SpaceIm · 2022-08-15T23:13:15Z

recipes/libcap/all/test_package/CMakeLists.txt


-include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)
-conan_basic_setup()
+find_package(PkgConfig REQUIRED)


please add pkgconf to build_requirements of test_package

conan-center-bot · 2022-08-16T19:57:45Z

All green in build 4 (e01ccdc9dd35b9e8fb74b6384ec9129318da3ce8):

libcap/2.62@:
All packages built successfully! (All logs)
libcap/2.45@:
All packages built successfully! (All logs)
libcap/2.58@:
All packages built successfully! (All logs)
libcap/2.48@:
All packages built successfully! (All logs)
libcap/2.57@:
All packages built successfully! (All logs)
libcap/2.46@:
All packages built successfully! (All logs)
libcap/2.65@:
All packages built successfully! (All logs)
libcap/2.50@:
All packages built successfully! (All logs)

bobrofon added 4 commits August 15, 2022 22:49

libcap/all: Fix invalid topics (KB-H064) warning

dbde3bd

WARN: [INVALID TOPICS (KB-H064)] The topic 'conan' is invalid and should be removed from topics attribute.

libcap/all: Fix tools cross building (KB-H062) warning

5d61048

WARN: [TOOLS CROSS BUILDING (KB-H062)] The 'tools.cross_building(self.settings)' syntax may not work correctly in some scenarios. Consider using tools.cross_building(self).

libcap/all: Use pkg_config generator in the test package

657eb43

libcap natively supports .pc files. And a minimal test package should check that at least the pkg_config generator works correctly (because this is how other packages typically work with libcap).

libcap/2.65: Bump version

0b20246

bobrofon force-pushed the libcap/2.65 branch from 0ff6c21 to 484f4a9 Compare August 15, 2022 20:14

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 15, 2022

bobrofon force-pushed the libcap/2.65 branch from 484f4a9 to aa1caaa Compare August 15, 2022 20:54

conan-center-bot removed the Failed label Aug 15, 2022

This comment has been minimized.

Sign in to view

bobrofon commented Aug 15, 2022

View reviewed changes

bobrofon marked this pull request as ready for review August 15, 2022 22:16

github-actions bot mentioned this pull request Aug 15, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SpaceIm reviewed Aug 15, 2022

View reviewed changes

libcap/all: cross-compatibility conan v1/v2

e01ccdc

bobrofon force-pushed the libcap/2.65 branch from aa1caaa to e01ccdc Compare August 16, 2022 18:52

uilianries approved these changes Aug 17, 2022

View reviewed changes

toge approved these changes Aug 24, 2022

View reviewed changes

conan-center-bot merged commit d0bcda3 into conan-io:master Aug 24, 2022

bobrofon deleted the libcap/2.65 branch August 24, 2022 20:26

prince-chrismc mentioned this pull request Aug 25, 2022

add the PKG_CONFIG_PATH via CMake build helper or even CMakeToolchain conan-io/conan#11962

Closed

prince-chrismc mentioned this pull request Sep 9, 2022

Conan 2.0 Migration Effort #12888

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libcap/2.65 + conan v2 compatibility #12241

libcap/2.65 + conan v2 compatibility #12241

bobrofon commented Aug 15, 2022

This comment has been minimized.

This comment has been minimized.

bobrofon Aug 15, 2022 •

edited

Loading

prince-chrismc Aug 24, 2022

bobrofon Aug 15, 2022

prince-chrismc Aug 24, 2022

franramirez688 Aug 25, 2022

SpaceIm Aug 15, 2022

SpaceIm Aug 15, 2022

bobrofon Aug 16, 2022

SpaceIm Aug 15, 2022

bobrofon Aug 16, 2022

SpaceIm Aug 15, 2022

bobrofon Aug 16, 2022

conan-center-bot commented Aug 16, 2022


		def package_info(self):
		self.cpp_info.components["cap"].set_property("pkg_config_name",


		required_conan_version = ">=1.33.0"
		required_conan_version = ">=1.37.0"

	required_conan_version = ">=1.37.0"
	required_conan_version = ">=1.47.0"

libcap/2.65 + conan v2 compatibility #12241

libcap/2.65 + conan v2 compatibility #12241

Conversation

bobrofon commented Aug 15, 2022

This comment has been minimized.

This comment has been minimized.

bobrofon Aug 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Aug 16, 2022

bobrofon Aug 15, 2022 •

edited

Loading