New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license and url of libcurl in conanfile.py #12568

Merged

conan-center-bot merged 4 commits into conan-io:master from BjoernAtBosch:patch-1

Sep 9, 2022

Contributor

BjoernAtBosch commented Aug 25, 2022 •

edited by uilianries

Loading

libcurl is provided under "curl" license - see https://curl.se/docs/copyright.html and https://spdx.org/licenses/curl.html
URL is https://curl.se

Specify library name and version: libcurl/7.10.4+

fixes #12566
fixes #12567

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.


          Fix license and url of libcurl in conanfile.py

033ffcd

libcurl is provided under "curl" license - see https://curl.se/docs/copyright.html and https://spdx.org/licenses/curl.html
URL is https://curl.se

CLAassistant commented Aug 25, 2022 •

edited

Loading

All committers have signed the CLA.

This comment has been minimized.

Sign in to view

conan-center-bot added the User-approval pending label

ghost mentioned this pull request

[service] Potentially conflicting recipes #3571

Closed

ghost commented Aug 25, 2022

I detected other pull requests that are modifying libcurl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

ghost mentioned this pull request

[libcurl/xxx] Conan v2 migration #12377

Closed

4 tasks

github-actions bot mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

uilianries reviewed

View reviewed changes

Member

uilianries left a comment

Thank you for your contribution. Please, don't forget to sign the CLA and ask for access on the issue #4.

recipes/libcurl/all/conanfile.py Show resolved Hide resolved


          Set license to MIT for versions before 7.10.4

df58b38

(patch provided by uilianries)

This comment has been minimized.

Sign in to view

BjoernAtBosch mentioned this pull request

[!!] Access request #4

Closed

prince-chrismc previously approved these changes

View reviewed changes

conan-center-bot removed the User-approval pending label

This comment has been minimized.

Sign in to view


          Update Conan tools imports

8659e8c

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Member

uilianries commented Sep 6, 2022

@BjoernAtBosch Please, consider https://github.com/BjoernAtBosch/conan-center-index/pull/1. It should fix your linter errors.


          Merge pull request #1 from uilianries/libcurl-license

67f4fd0

[libcurl] Update tools imports

BjoernAtBosch dismissed prince-chrismc’s stale review via

67f4fd0

September 6, 2022 07:37

Collaborator

conan-center-bot commented Sep 6, 2022

All green in build 5 (67f4fd05159b1e530901d8524b580b0e0bbc697c):

libcurl/7.83.1@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libcurl/7.84.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libcurl/7.80.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libcurl/7.79.1@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libcurl/7.78.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libcurl/7.76.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libcurl/7.82.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

libcurl/7.77.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12568/recipes/libcurl/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, AutoToolsBuildEnvironment, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

uilianries approved these changes

View reviewed changes

jgsogo approved these changes

View reviewed changes

conan-center-bot merged commit 64e1df2 into conan-io:master

BjoernAtBosch deleted the patch-1 branch

September 9, 2022 14:05

sschuberth mentioned this pull request

ConanFunTest: Update the expected output oss-review-toolkit/ort#5765

Merged

ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request


          (conan-io#12568) Fix license and url of libcurl in conanfile.py

805e635

* Fix license and url of libcurl in conanfile.py

libcurl is provided under "curl" license - see https://curl.se/docs/copyright.html and https://spdx.org/licenses/curl.html
URL is https://curl.se

* Set license to MIT for versions before 7.10.4

(patch provided by uilianries)

* Update Conan tools imports

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet