Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seasocks v1.4.5 #12667

Closed
wants to merge 1 commit into from
Closed

Conversation

mattgodbolt
Copy link
Contributor

Specify library name and version: seasocks/1.4.5

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@prince-chrismc
Copy link
Contributor

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

@uilianries
Copy link
Member

I just re-triggered right now.

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Aug 30, 2022
@conan-center-bot
Copy link
Collaborator

Failure in build 3 (a79bce977b710ac92f6d8c9a5218adf7c89495c9):

  • seasocks/1.4.5@:
    CI failed to create some packages (All logs)

    Logs for packageID a015930a9d9a9177506d380af2818c61ca961334:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    seasocks:shared=False
    
    [...]
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
    -- Looking for pthread_create in pthreads
    -- Looking for pthread_create in pthreads - not found
    -- Looking for pthread_create in pthread
    -- Looking for pthread_create in pthread - found
    -- Found Threads: TRUE  
    -- Found PythonInterp: /opt/pyenv/versions/3.7.13/bin/python (found version "3.7.13") 
    -- Using Python: '/opt/pyenv/versions/3.7.13/bin/python'
    -- Conan: Using autogenerated FindZLIB.cmake
    -- Found ZLIB: 1.2.12 (found version "1.2.12") 
    -- Library z found /home/conan/w/prod/BuildSingleReference/.conan/data/zlib/1.2.12/_/_/package/76f87539fc90ff313e0b3182641a9bb558a717d2/lib/libz.a
    -- Found: /home/conan/w/prod/BuildSingleReference/.conan/data/zlib/1.2.12/_/_/package/76f87539fc90ff313e0b3182641a9bb558a717d2/lib/libz.a
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/prod/BuildSingleReference/.conan/data/seasocks/1.4.5/_/_/build/a015930a9d9a9177506d380af2818c61ca961334
    
    ----Running------
    > cmake --build '/home/conan/w/prod/BuildSingleReference/.conan/data/seasocks/1.4.5/_/_/build/a015930a9d9a9177506d380af2818c61ca961334' '--' '-j3'
    -----------------
    [  4%] Generating embedded content
    Scanning dependencies of target embedded
    [  8%] Building CXX object source_subfolder/src/main/web/CMakeFiles/embedded.dir/Embedded.cpp.o
    [  8%] Built target embedded
    Scanning dependencies of target seasocks
    [ 20%] Building CXX object source_subfolder/src/main/c/CMakeFiles/seasocks.dir/HybiAccept.cpp.o
    [ 20%] Building CXX object source_subfolder/src/main/c/CMakeFiles/seasocks.dir/Connection.cpp.o
    [ 20%] Building CXX object source_subfolder/src/main/c/CMakeFiles/seasocks.dir/HybiPacketDecoder.cpp.o
    source_subfolder/src/main/c/CMakeFiles/seasocks.dir/build.make:81: recipe for target 'source_subfolder/src/main/c/CMakeFiles/seasocks.dir/Connection.cpp.o' failed
    CMakeFiles/Makefile2:953: recipe for target 'source_subfolder/src/main/c/CMakeFiles/seasocks.dir/all' failed
    Makefile:148: recipe for target 'all' failed
    seasocks/1.4.5: 
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    
    
    In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/seasocks/1.4.5/_/_/build/a015930a9d9a9177506d380af2818c61ca961334/source_subfolder/src/main/c/internal/HeaderMap.h:32:0,
                     from /home/conan/w/prod/BuildSingleReference/.conan/data/seasocks/1.4.5/_/_/build/a015930a9d9a9177506d380af2818c61ca961334/source_subfolder/src/main/c/Connection.cpp:28:
    /home/conan/w/prod/BuildSingleReference/.conan/data/seasocks/1.4.5/_/_/build/a015930a9d9a9177506d380af2818c61ca961334/source_subfolder/src/main/c/./seasocks/StrCompare.h:5:23: fatal error: string_view: No such file or directory
    compilation terminated.
    make[2]: *** [source_subfolder/src/main/c/CMakeFiles/seasocks.dir/Connection.cpp.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    make[1]: *** [source_subfolder/src/main/c/CMakeFiles/seasocks.dir/all] Error 2
    make: *** [all] Error 2
    seasocks/1.4.5: ERROR: Package 'a015930a9d9a9177506d380af2818c61ca961334' build failed
    seasocks/1.4.5: WARN: Build folder /home/conan/w/prod/BuildSingleReference/.conan/data/seasocks/1.4.5/_/_/build/a015930a9d9a9177506d380af2818c61ca961334
    ERROR: seasocks/1.4.5: Error in build() method, line 75
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/home/conan/w/prod/BuildSingleReference/.conan/data/seasocks/1.4.5/_/_/build/a015930a9d9a9177506d380af2818c61ca961334' '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@mattgodbolt
Copy link
Contributor Author

Oh darn; thanks all. Will take a look at the build error. Our internal CI passed ok, but obviously something else is up.

@mattgodbolt
Copy link
Contributor Author

Apologies; it seems we picked up a <string_view> dependency for our tests that isn't properly declared so GCC 5 builds are failing here. Will fix upstream. Sorry for the trouble!

@uilianries
Copy link
Member

@mattgodbolt At least our CI pointed a "bug" 😄

@mattgodbolt
Copy link
Contributor Author

@uilianries yes! :) Though if we were to stop supporting gcc 5 (which says it's c++17 but lies about string_view) how do we communicate to conan to not build us for that version? I'm actually going to "fix" this and put a workaround for gcc 5 but...if we wanted to drop support how do we say so?

@prince-chrismc
Copy link
Contributor

prince-chrismc commented Aug 30, 2022

We have this pattern

def _compilers_minimum_version(self):

it's also in conan-io/conan#8002 🤞

@mattgodbolt
Copy link
Contributor Author

Thanks @prince-chrismc ! Much appreciated! I'll close this PR and come back when we have fixed things on our side. Which will be v1.4.6 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump version PR bumping version without recipe modifications Failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants