qwt: Use Cmake instead of qmake

[EstebanDugueperoux2]

Specify library name and version: qwt/6.2.0

---

• [x ] I've read the guidelines for contributing.
• [ x] I've followed the PEP8 style guides for Python code in the recipes.
• [ x] I've used the latest Conan client version.
• [ x] I've tried at least one configuration locally with the conan-center hook activated.

[ericLemanissier]

I don't think it's acceptable to introduce a 6.2.1 version which actually packages 6.2.0, because official 6.2.1 will come some day. Also, there should in theory be no difference between the existing 6.2.0 binaries and the binaries built from this PR.
if @MehdiChinoune's license allows it, I think it would be best to extract the relevant CMakeLists.txt files from his repo, add them to the recipe's folder and add them to export_sources attribute.

[ghost]

I detected other pull requests that are modifying qwt/all recipe:

• qwt: add qt to tool_requirements #12831

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[ericLemanissier]

thanks !

[ericLemanissier]

Thanks!

[EstebanDugueperoux2]

@uilianries @jgsogo Could you review this PR please?
Regards.

[conan-center-bot]

All green in build 39 (f5917e59f880fc2eb2b8084044762030c448498e):

• qwt/6.2.0@:
  All packages built successfully! (All logs)

[ericLemanissier]

your force-pushed again. I don't have time to re-review a thousand lines change.

[EstebanDugueperoux2]

your force-pushed again. I don't have time to re-review a thousand lines change.

It was only to have a single commit in the history instead of many draft commits.
I have don't make code changes since your last approval.

[ericLemanissier]

https://github.com/conan-io/conan-center-index/blob/304d808ff74d68da12802fb88417a255d5de269e/docs/review_process.md#automatic-merges

The conan-center-bot will perform a squash and merge. You don't need to rebase your pull request, we ask you not to do it because it will dismiss any reviews and the reviewer will need to restart.

[EstebanDugueperoux2]

https://github.com/conan-io/conan-center-index/blob/304d808ff74d68da12802fb88417a255d5de269e/docs/review_process.md#automatic-merges

The conan-center-bot will perform a squash and merge. You don't need to rebase your pull request, we ask you not to do it because it will dismiss any reviews and the reviewer will need to restart.

Ok sorry for the disturb.

[SpaceIm]

There are thousands lines from a fork, who will maintain that in CCI? I mean there are tones of CMakeLists we don't even care about in CCI, related to examples.
Was it submitted upstream?

If upstream is not interested, I would prefer a custom CMakeLists exported with the recipe (nobody wants to maintain big CMakeLists in patches), or go back to qmake...

[ericLemanissier]

It was proposed upstream in https://sourceforge.net/p/qwt/feature-requests/95/#397d/9909
For the reason why this patch is needed, see #12830 (comment)

[SpaceIm]

In https://sourceforge.net/p/qwt/feature-requests/95/#397d/9909, it's not clear whether these patches will be included in the near future.

[SpaceIm]

And in patch_source, a link to a commit would be more useful.

[uilianries]

Indeed, patch_source helps a lot on that case.

[fdgStilla]

the error happens because qwt 6.1.6 is built with qmake, and qmake saves hardcoded path to qt dependencies during qt build. these paths are incorrect during qwt build because CCI uses a different folder for conan cache during each CI build

Hi @ericLemanissier, I created a package for qt installer framework (https://doc.qt.io/qtinstallerframework/ifw-getting-started.html#building-from-sources) and everything was fine when I was building the qt package (it needs some options disabled in conan center CI) and the qt installer framework on the same machine.

But now I am trying to create the package on different machine (because of our own CI architecture) and I am facing the issue you describe: the path of the qt dependencies are hardcoded in the qmake file.
As a specific example: lib/Qt5FontDatabaseSupport.prl reference a hardcoded path to freetype.lib

Do you have a solution to suggest? I don't think we can use another make tool to compile the qt installer framework and I do not see any workaround to fix the hardcoded paths.

[ericLemanissier]

the (not so) quick and easy solution is to rebuild qt locally (-b qt command line argument)
the proper fix would be to patch all prl files. You could take a look at what vcpkg does: https://github.com/microsoft/vcpkg/blob/f9bea5d58186dc14e7e33132e43b52222147f51e/ports/qtbase/cmake/qt_install_submodule.cmake#L198

[fdgStilla]

Ok thanks for the answer, like you said building qt locally is a (painful) solution but unfortunately I won't have the skill/time to patch qt.