Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[m4] conan v2 #12892

Closed
wants to merge 22 commits into from
Closed

Conversation

jellespijker
Copy link
Contributor

@jellespijker jellespijker commented Sep 10, 2022

Specify library name and version: m4/x.x.x

I thook the liberty of defining a conf value: tools.m4:bin which is the path to the binary m4 executable. I don't know if tools is a reserved namespace but it maid sense in my mind. Let me know if that should change.

Based on this template:
https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/autotools_package

Contribute to CURA-9595


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@jellespijker jellespijker mentioned this pull request Sep 10, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

Contribute to CURA-9595
@conan-center-bot

This comment has been minimized.

Contribute to CURA-9595
Contribute to CURA-9595
@conan-center-bot

This comment has been minimized.

Contribute to CURA-9595
@conan-center-bot

This comment has been minimized.

Contribute to CURA-9595
@conan-center-bot

This comment has been minimized.

Contributes to CURA-9595
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Contribute to CURA-9595
@conan-center-bot

This comment has been minimized.

Contributes to CURA-9595
@conan-center-bot

This comment has been minimized.

Contributes to CURA-9595
@conan-center-bot

This comment has been minimized.

Contributes to CURA-9595
@conan-center-bot
Copy link
Collaborator

Failure in build 15 (32df120fdb0d80dd723abb4593b4ba13c11d5cb6):

  • m4/1.4.19@:
    Didn't run or was cancelled before finishing

  • m4/1.4.18@:
    CI failed to create some packages (All logs)

    Logs for packageID 01edd76db8e16db9b38c3cca44ec466a9444c388:
    [settings]
    arch=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MTd
    compiler.version=15
    os=Windows
    
    [...]
    ----Running------
    > "C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\m4\all\test_package\build\1a4cddef17ccb591e1e9b63fcd40b2032455545e\conanbuild.bat" && C:/J/w/prod/BuildSingleReference@2/.conan/data/m4/1.4.18/_/_/package/01edd76db8e16db9b38c3cca44ec466a9444c388\bin\m4 -R C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\m4\all\test_package\frozen.m4f C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\m4\all\test_package\test.m4
    -----------------
    Capturing current environment in C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\m4\all\test_package\build\1a4cddef17ccb591e1e9b63fcd40b2032455545e\deactivate_conanbuildenv-debug-x86_64.bat
    Configuring environment variables
    Hello Conan World
    All letters: ��������	
    �
    ������������������ !"#*%&'()$+,./0123456789:;<=>?@[\]^_`{|}~���������������������������������������������������������������������������������������������������������������������������������-
    ********************************************************************************
    conan test conan-center-index\recipes\m4\all\test_v1_package\conanfile.py m4/1.4.18@#3977b16765ffaa616ab699c3adcc1efa -pr C:\J\w\prod\BuildSingleReference@2\91316\df7070de-b921-4ecc-91de-f9acc7fa6864/profile_windows_15_mtd_vs_debug_64..txt -c tools.system.package_manager:mode=install -c tools.system.package_manager:sudo=True
    ********************************************************************************
    Configuration:
    [settings]
    arch=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MTd
    compiler.version=15
    os=Windows
    [options]
    [build_requires]
    [env]
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    m4/1.4.18 (test package): Installing package
    Requirements
        m4/1.4.18 from local cache - Cache
    Packages
        m4/1.4.18:01edd76db8e16db9b38c3cca44ec466a9444c388 - Cache
    
    Installing (downloading, building) binaries...
    m4/1.4.18: Already installed!
    m4/1.4.18: Appending PATH environment variable: C:\J\w\prod\BuildSingleReference@2\.conan\data\m4\1.4.18\_\_\package\01edd76db8e16db9b38c3cca44ec466a9444c388\bin
    m4/1.4.18: Define M4 with C:\J\w\prod\BuildSingleReference@2\.conan\data\m4\1.4.18\_\_\package\01edd76db8e16db9b38c3cca44ec466a9444c388\bin\m4.exe
    m4/1.4.18: Defining path to M4 binary in configuration as `tools.m4:bin` with value: C:\J\w\prod\BuildSingleReference@2\.conan\data\m4\1.4.18\_\_\package\01edd76db8e16db9b38c3cca44ec466a9444c388\bin\m4.exe
    m4/1.4.18 (test package): Generator txt created conanbuildinfo.txt
    m4/1.4.18 (test package): Aggregating env generators
    m4/1.4.18 (test package): Generated conaninfo.txt
    m4/1.4.18 (test package): Generated graphinfo
    Using lockfile: 'C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\m4\all\test_v1_package\build\1a4cddef17ccb591e1e9b63fcd40b2032455545e/conan.lock'
    Using cached profile from lockfile
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not found
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    m4/1.4.18 (test package): Calling build()
    m4/1.4.18 (test package): Running test()
    ERROR: m4/1.4.18 (test package): Error in test() method, line 30
    	raise ConanException("M4 environment variable not set")
    	ConanException: M4 environment variable not set
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@@ -1,130 +1,135 @@
from conans import ConanFile, tools, AutoToolsBuildEnvironment
from contextlib import contextmanager
import functools
import os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter

Suggested change
import os

@prince-chrismc
Copy link
Contributor

Once this pass we can merge then follow up with fixes... it's super complicated but keep up the amazing work

@prince-chrismc
Copy link
Contributor

seems like #13135 made it in first

@jellespijker
Copy link
Contributor Author

seems like #13135 made it in first

Will close this PR in favor of #13135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants