Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STLab] upgrade version to 1.7.1 #13048

Merged
merged 85 commits into from
Jun 26, 2023
Merged

[STLab] upgrade version to 1.7.1 #13048

merged 85 commits into from
Jun 26, 2023

Conversation

fpelliccioni
Copy link
Contributor

@fpelliccioni fpelliccioni commented Sep 20, 2022 •
edited
Loading

Specify library name and version: stlab/1.7.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Sep 20, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot removed Failed Bump version PR bumping version without recipe modifications labels Sep 20, 2022
@github-actions github-actions bot mentioned this pull request Sep 20, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Sep 21, 2022
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@franramirez688
Copy link
Contributor

@fpelliccioni please, try to sign the CLA (#13048 (comment)) whenever you can. It was updated a few weeks ago, so we had to sign it again.

@conan-center-bot

This comment has been minimized.

Sign in to view
@fpelliccioni
Copy link
Contributor Author

@fpelliccioni please, try to sign the CLA (#13048 (comment)) whenever you can. It was updated a few weeks ago, so we had to sign it again.

Done!
Thanks for the remainder

franramirez688
franramirez688 reviewed Jun 23, 2023
View reviewed changes
recipes/stlab/all/conanfile.py
tc.variables["STLAB_THREAD_SYSTEM"] = self.options.thread_system
tc.variables["STLAB_TASK_SYSTEM"] = self.options.task_system
if cross_building(self):
tc.variables["STLAB_HAVE_FUNCTIONAL_VARIANT_OPTIONAL"] = True
Copy link
Contributor

@franramirez688 franramirez688 Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpelliccioni is this OK? I had to add it otherwise It was failing.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
franramirez688
franramirez688 previously approved these changes Jun 26, 2023
View reviewed changes
@fpelliccioni
Copy link
Contributor Author

Thank you very much @franramirez688

AbrilRBS
AbrilRBS reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's bump Boost before merging, otherwise looks great :)

recipes/stlab/all/conanfile.py Outdated Show resolved Hide resolved
@fpelliccioni
Copy link
Contributor Author

Thanks! Let's bump Boost before merging, otherwise looks great :)

Bumped to 1.82

@AbrilRBS
Copy link
Member

Oops, you're totally right! Missremembered the latest boost version, thanks for the quick fix :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 83 (58ba8594b21e44dd4478102dc6453d2288467f48):

  • stlab/1.7.1@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 80 (58ba8594b21e44dd4478102dc6453d2288467f48):

  • stlab/1.7.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit e56f39f into conan-io:master Jun 26, 2023
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
@fpelliccioni @uilianries
@prince-chrismc @franramirez688 @AbrilRBS @pezy
(conan-io#13048) [STLab] upgrade version to 1.7.1
9b63c0e 
* [STLab] upgrade to 1.7.0

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* version 1.7.1

* fixes

* fix test recipe

* fix test recipe

* uses cmake v23

* fixes

* adds short_paths = True

* remove share folder

* temp removal of old files

* fix text package

* fix

* skip coying systems libs

* NOMINMAX

* fix

* fix

* define NOMINMAX on conan recipe

* now try all the versions

* fix

* remove old versions (temp)

* remove old versions (temp)

* rollback

* fixes

* fix

* fix

* fix

* fix

* Update recipes/absent/all/conanfile.py

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/stlab/1.7.0_and_above/conanfile.py

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/stlab/1.7.0_and_above/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* with_boost

* no test option

* fix

* Trigger notification

* fix

* fixes

* fixes 2

* Update recipes/bertrand/all/conanfile.py

* fixes 3

* Trigger notification

* fix linting

* fix linting

* remove dead code

* Update recipes/stlab/old/conandata.yml

* Update recipes/stlab/old/conandata.yml

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/stlab/old/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* remove dead code

* fix linter warnings

* Update recipes/stlab/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* reduce nesting

* Update recipes/stlab/old/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/stlab/old/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* review suggestions

* set CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP

* test things

* remove Windows runtime libs

* Update conanfile.py

* Refactoring and fixing errors

* putting self.ref instead of self.name

* suggestions

* Removed old versions

* Added new CMake var

* Update recipes/stlab/all/conanfile.py

* Update conanfile.py

---------

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
SpaceIm
SpaceIm reviewed Aug 8, 2023
View reviewed changes
recipes/stlab/all/conanfile.py
Comment on lines 126 to +131
def configure(self):
if self.options.task_system == "auto":
self.options.task_system = self._default_task_system()
self.output.info("Stlab Task System: {}.".format(self.options.task_system))
self.output.info("STLab With Boost: {}.".format(self.options.with_boost))
self.output.info("STLab Future Coroutines: {}.".format(self.options.future_coroutines))
self.output.info("STLab No Standard Coroutines: {}.".format(self.options.no_std_coroutines))
self.output.info("STLab Task System: {}.".format(self.options.task_system))
self.output.info("STLab Thread System: {}.".format(self.options.thread_system))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to remove these messages? It's quite weird to see these messages under ======== Computing dependency graph ======== in conan v2, and from my point of view it's the job of upstream build system to display these informations at build time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be done in another PR. This one is already merged

@fpelliccioni fpelliccioni deleted the feat/upgrade-stlab branch August 14, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm left review comments

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

@prince-chrismc prince-chrismc Awaiting requested review from prince-chrismc

@uilianries uilianries Awaiting requested review from uilianries

@danimtb danimtb Awaiting requested review from danimtb

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@fpelliccioni @conan-center-bot @uilianries @prince-chrismc @AbrilRBS @CLAassistant @franramirez688 @SpaceIm