Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlohmann_json: small improvements #13120

Merged
merged 2 commits into from
Sep 27, 2022
Merged

nlohmann_json: small improvements #13120

merged 2 commits into from
Sep 27, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Sep 23, 2022

  • avoid to propagate empty bin/lib/res dirs
  • check min cppstd
  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Sep 23, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries previously approved these changes Sep 26, 2022
View reviewed changes
@conan-center-bot
Copy link
Collaborator

All green in build 2 (b9a36c91c85783015483530804508d5984c12a44):

  • nlohmann_json/3.1.1@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.7.0@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.9.0@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.2.0@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.10.5@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.7.3@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.11.0@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.11.2@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.4.0@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.10.2@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.10.0@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.9.1@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.11.1@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.10.3@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.8.0@:
    All packages built successfully! (All logs)

  • nlohmann_json/3.10.4@:
    All packages built successfully! (All logs)

jwillikers
jwillikers approved these changes Sep 26, 2022
View reviewed changes
recipes/nlohmann_json/all/conanfile.py
def generate(self):
pass
def validate(self):
if self.settings.compiler.get_safe("cppstd"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be self.info.settings.compiler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but can't work in conan v1 if there is self.info.clear() in package_id()

@conan-center-bot conan-center-bot merged commit 20994c6 into conan-io:master Sep 27, 2022
@SpaceIm SpaceIm deleted the nlohmann_json-few-improvements branch September 27, 2022 07:29
kayoub5 pushed a commit to kayoub5/conan-center-index that referenced this pull request Sep 29, 2022
@SpaceIm @kayoub5
(conan-io#13120) nlohmann_json: small improvements
df01efb 
* tiny improvements

* Update recipes/nlohmann_json/all/conanfile.py
@prince-chrismc prince-chrismc mentioned this pull request Oct 5, 2022
Closed
System-Arch pushed a commit to System-Arch/conan-center-index that referenced this pull request Oct 7, 2022
@SpaceIm @marc-mw
(conan-io#13120) nlohmann_json: small improvements
6b9c745 
* tiny improvements

* Update recipes/nlohmann_json/all/conanfile.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries approved these changes

@toge toge toge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceIm @conan-center-bot @toge @uilianries @jwillikers