Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtest: set the correct required_conan_version + few minor fixes #13121

Merged
merged 5 commits into from
Sep 27, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Sep 23, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (c6e8c92112bea0e72e0d5bc4716e37b096e06df1):

  • gtest/1.12.1@:
    All packages built successfully! (All logs)

@ghost
Copy link

ghost commented Sep 26, 2022

I detected other pull requests that are modifying gtest/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 67d66b5 into conan-io:master Sep 27, 2022
@SpaceIm SpaceIm deleted the fix/gtest branch September 27, 2022 07:29
kayoub5 pushed a commit to kayoub5/conan-center-index that referenced this pull request Sep 29, 2022
…minor fixes

* update required_conan_version

1.51.1 is needed due to get_safe in self.info

* reorder methods

* use self.info in validate()

* fix indentation

* protect deletion of fPIC
System-Arch pushed a commit to System-Arch/conan-center-index that referenced this pull request Oct 7, 2022
…minor fixes

* update required_conan_version

1.51.1 is needed due to get_safe in self.info

* reorder methods

* use self.info in validate()

* fix indentation

* protect deletion of fPIC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants