-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtest: set the correct required_conan_version + few minor fixes #13121
Conversation
1.51.1 is needed due to get_safe in self.info
All green in build 1 (
|
I detected other pull requests that are modifying gtest/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…minor fixes * update required_conan_version 1.51.1 is needed due to get_safe in self.info * reorder methods * use self.info in validate() * fix indentation * protect deletion of fPIC
…minor fixes * update required_conan_version 1.51.1 is needed due to get_safe in self.info * reorder methods * use self.info in validate() * fix indentation * protect deletion of fPIC
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!