Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmtlog: add recipe #13167

Merged
merged 10 commits into from
Oct 10, 2022
Merged

fmtlog: add recipe #13167

merged 10 commits into from
Oct 10, 2022

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 27, 2022

Specify library name and version: fmglog/2.2.1

fmtlog is a faster logging library which uses fmt.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Open
uilianries
uilianries reviewed Sep 27, 2022
View reviewed changes
recipes/fmtlog/all/conanfile.py Outdated Show resolved Hide resolved
recipes/fmtlog/all/conanfile.py Outdated Show resolved Hide resolved
recipes/fmtlog/all/conanfile.py Outdated Show resolved Hide resolved
recipes/fmtlog/all/conanfile.py Show resolved Hide resolved
toge and others added 2 commits September 27, 2022 23:48
@toge @uilianries
fix license name
19f6933 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@toge @uilianries
remove comment of template
da3de50 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
toge and others added 2 commits September 28, 2022 00:59
@toge @uilianries
use self.info.settings
29c2ba5 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@toge @uilianries
use self.info.settings part 2
d4d88fc 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Copy link
Member

It seems like GCC5 does not understand std::enable_if. Not sure if -std=c++11 is missing or the compiler does not support it, because it's a C++11 feature.

@toge
Copy link
Contributor Author

toge commented Sep 28, 2022

@uilianries
Thank you for your advice.
I think my validate() is wrong.
I'm trying to fix it.

@toge
Copy link
Contributor Author

toge commented Sep 29, 2022

@uilianries
Specifying header-only=True with gcc 5 results in a compile error.
If I specify gcc 5 with header-only=False, it will not compile with validation error.

The same cause occurs with svector. #13170.

I believe your issue in conan-dev will solve the problems.

@uilianries
Copy link
Member

@toge I suggest you using self.settings.compiler on validate() for now. Probably it will require a hotfix which we can update later.

@toge @uilianries
use self.settings instead of self.info.settings (workaround)
e73c180 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries previously approved these changes Oct 3, 2022
View reviewed changes
jwillikers
jwillikers suggested changes Oct 4, 2022
View reviewed changes
recipes/fmtlog/all/conanfile.py
destination=self.source_folder, strip_root=True)

def generate(self):
tc = CMakeToolchain(self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to skip the generators when building header_only?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not using cmake to install files, yes, it's totally possible, just need to check the related option header_only and skip it.

uilianries
uilianries reviewed Oct 5, 2022
View reviewed changes
recipes/fmtlog/all/conanfile.py Outdated Show resolved Hide resolved
recipes/fmtlog/all/conanfile.py Outdated Show resolved Hide resolved
recipes/fmtlog/all/conanfile.py Show resolved Hide resolved
prince-chrismc
prince-chrismc reviewed Oct 6, 2022
View reviewed changes
recipes/fmtlog/all/patches/2.2.1-0001-fix-cmake.patch
@@ -0,0 +1,39 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit this upstream!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not needed for upstream because upstream uses internal fmtlib.

prince-chrismc
prince-chrismc reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some good suggestions above 😄

@toge @uilianries
remove VirtualBuildENv
d6a45c5 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
toge and others added 2 commits October 7, 2022 18:55
@toge @uilianries
remove VirtualBuildEnv(2)
06d8613 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@toge @uilianries
first return if header_only
f71efe8 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 10 (f71efe817837f4603425f88f2489a307add5b0c4):

  • fmtlog/2.2.1@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 6b771d6 into conan-io:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc left review comments

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toge @conan-center-bot @uilianries @prince-chrismc @jwillikers