Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-c-io: add version 0.13.4 and support conan v2 #13304

Merged
merged 1 commit into from
Oct 5, 2022
Merged

aws-c-io: add version 0.13.4 and support conan v2 #13304

merged 1 commit into from
Oct 5, 2022

Conversation

toge
Copy link
Contributor

@toge toge commented Oct 4, 2022

Specify library name and version: aws-c-io/*

  • add version 0.13.4
  • support conan v2
  • update dependencies
  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Oct 4, 2022
Open
Closed
@toge toge closed this Oct 4, 2022
@toge toge reopened this Oct 5, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 2 (641731435c029c981a3c056ec8aac5a5ad0d479d):

  • aws-c-io/0.11.2@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.20@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.13@:
    All packages built successfully! (All logs)

  • aws-c-io/0.13.4@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.5@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.9@:
    All packages built successfully! (All logs)

@github-actions github-actions bot mentioned this pull request Oct 5, 2022
Open
uilianries
uilianries approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit c4aacc9 into conan-io:master Oct 5, 2022
SpaceIm
SpaceIm reviewed Oct 6, 2022
View reviewed changes
recipes/aws-c-io/all/conanfile.py
import os

required_conan_version = ">=1.43.0"

required_conan_version = ">=1.52.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 1.52.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really needed, but okay

System-Arch pushed a commit to System-Arch/conan-center-index that referenced this pull request Oct 7, 2022
@toge @marc-mw
(conan-io#13304) aws-c-io: add version 0.13.4 and support conan v2
484a54d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@SpaceIm SpaceIm SpaceIm left review comments

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@jwillikers jwillikers jwillikers approved these changes

@jgsogo jgsogo Awaiting requested review from jgsogo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toge @conan-center-bot @uilianries @prince-chrismc @jwillikers @SpaceIm