Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Apply python black formatter over recipe templates #13331

Merged
merged 3 commits into from
Oct 6, 2022
Merged

[docs] Apply python black formatter over recipe templates #13331

merged 3 commits into from
Oct 6, 2022

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Oct 6, 2022 •
edited
Loading

closes #13289

  • Using 120 chars as max line length

/cc @winterz

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@uilianries
Apply python black
53ea2a7 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 6, 2022
Open
@SSE4
Copy link
Contributor

SSE4 commented Oct 6, 2022

I personally don't think it looks/reads better... code is too long, and has too many lines instead of single, easy to read line

jwillikers
jwillikers previously approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you. Formatting consistency makes diffing that much easier and Black is nice and easy to use.

@uilianries
Update to 120 chars
3bd4628 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Update to 120 chars
d5486d4 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

I just updated to 120 chars.

@conan-center-bot conan-center-bot added Docs and removed Docs labels Oct 6, 2022
@prince-chrismc
Copy link
Contributor

we should write a pipeline for these and build them 🙈

@conan-center-bot conan-center-bot merged commit 9cd0fcb into conan-io:master Oct 6, 2022
System-Arch pushed a commit to System-Arch/conan-center-index that referenced this pull request Oct 7, 2022
@uilianries @marc-mw
(conan-io#13331) [docs] Apply python black formatter over recipe temp…
d04f887 
…lates

* Apply python black

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update to 120 chars

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update to 120 chars

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@jwillikers jwillikers jwillikers approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[service] linter clean the cmake_package template
5 participants
@uilianries @SSE4 @prince-chrismc @jwillikers @conan-center-bot