Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openssl 1.0.2x shared library permissions #134

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Fix openssl 1.0.2x shared library permissions #134

merged 1 commit into from
Oct 24, 2019

Conversation

Talkless
Copy link
Contributor

Invoking conan install second time fails if openssl/1.0.2x package is used.
Shared libraries are built with permissions restricting owner to write, a behaviour that produces mentioned install failure.

Update openssl recipe to fix shared library permissions on Unix-like systems.

Closes conan-io/conan#5831

Specify library name and version: openssl/1.0.2t

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@Talkless Talkless mentioned this pull request Sep 29, 2019
Closed
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

1 similar comment
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

Some configurations of 'openssl/1.0.2s' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: openssl:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [META LINES (KB-H025)] PEP 263 (encoding) is not allowed in the conanfile. Remove the line 1 (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H025)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@Talkless
Copy link
Contributor Author

@lasote KB-H025 is some new rule? My PR has nothing to do with that... Do I fix it here with additional commit, or some other PR should be done (and rebase this)?

@lasote
Copy link
Contributor

lasote commented Oct 10, 2019

Yes, sorry, we introduced some more checks. You can fix here.

@Talkless
Copy link
Contributor Author

@SSE4 could you take a look at this again? I've fixed hook error.

SSE4
SSE4 previously approved these changes Oct 14, 2019
View reviewed changes
@Talkless
Copy link
Contributor Author

Oh, looks like second reviewer is needed. @SSE4 any idea who could provide that?

@SSE4
Copy link
Contributor

SSE4 commented Oct 15, 2019

@uilianries @danimtb

uilianries
uilianries previously approved these changes Oct 22, 2019
View reviewed changes
@uilianries uilianries closed this Oct 22, 2019
@uilianries uilianries reopened this Oct 22, 2019
danimtb
danimtb previously approved these changes Oct 22, 2019
View reviewed changes
@danimtb
Copy link
Member

danimtb commented Oct 22, 2019

@Talkless could you please update this PR with the latest changes on master? The OpenSSL was updated by a previous PR and I'd like to ensure the packages are compiled with those changes too. Thanks!

@conan-center-bot
Copy link
Collaborator

All green! 😊

@Talkless
Fix openssl 1.0.2x shared library permissions
5a09f9e 
Invoking `conan install` second time fails if openssl/1.0.2x package is used.
Shared libraries are built with permissions restricting owner to write, a
behaviour that produces mentioned install failure.

Update openssl recipe to fix shared library permissions on Unix-like systems.

Closes conan-io/conan#5831
@Talkless Talkless dismissed stale reviews from danimtb and uilianries via 5a09f9e October 22, 2019 12:54
@Talkless
Copy link
Contributor Author

@SSE4 @danimtb I've rebased on latest master.

@Talkless Talkless requested review from SSE4 and danimtb October 22, 2019 12:59
@lasote lasote closed this Oct 23, 2019
@lasote lasote reopened this Oct 23, 2019
@conan-center-bot
Copy link
Collaborator

All green! 😊

@Talkless
Copy link
Contributor Author

Ping @SSE4, your final review is need.

@lasote lasote merged commit 01f3d33 into conan-io:master Oct 24, 2019
@Talkless Talkless deleted the fix-openssl-perms branch October 24, 2019 18:23
artem-kamyshev pushed a commit to artem-kamyshev/conan-center-index that referenced this pull request Sep 28, 2020
@borune-k12
Merge pull request conan-io#134 from borune-k12/openal
53bee1a 
build openal with gcc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Permission denied" when running conan install . second time and imported symlink already exists
7 participants
@Talkless @CLAassistant @conan-center-bot @lasote @SSE4 @danimtb @uilianries