Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cityhash: conan v2 support #13446

Merged
merged 4 commits into from
Jan 12, 2023
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 12, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

jwillikers
jwillikers previously approved these changes Oct 14, 2022
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 14, 2022

c1xx: fatal error C1083: Cannot open source file: 'C:J:/w/prod/buildsinglereference/.conan/data/cityhash/cci.20130801/_/_/build/6cc50b139b9c3d27b3e9042d5f5372d327b3a9f7/src/src/city.cc': No such file or directory
make[2]: Leaving directory '/c/J/w/prod/BuildSingleReference/.conan/data/cityhash/cci.20130801/_/_/build/6cc50b139b9c3d27b3e9042d5f5372d327b3a9f7/build-release/src'
make[1]: Leaving directory '/c/J/w/prod/BuildSingleReference/.conan/data/cityhash/cci.20130801/_/_/build/6cc50b139b9c3d27b3e9042d5f5372d327b3a9f7/build-release'
cityhash/cci.20130801: 
configure.ac:15: installing './compile'
configure.ac:13: installing './missing'
src/Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'
make[2]: *** [Makefile:643: city.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:454: all-recursive] Error 1
make: *** [Makefile:365: all] Error 2

I can't test on Windows due to #9002

@SpaceIm SpaceIm mentioned this pull request Nov 10, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

jwillikers
jwillikers previously approved these changes Nov 11, 2022
@SpaceIm SpaceIm closed this Nov 11, 2022
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 11, 2022

I don't understand why it can't find cxx files when compiler is visual studio. I know that with legacy generators it was mandatory to build from source folder but it's not possible with the conan v2 way.

@SpaceIm SpaceIm reopened this Nov 11, 2022
@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Dec 11, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 11, 2022
jwillikers
jwillikers previously approved these changes Jan 7, 2023
@SpaceIm SpaceIm closed this Jan 9, 2023
@SpaceIm SpaceIm reopened this Jan 9, 2023
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Hooks produced the following warnings for commit 7345344
cityhash/cci.20130801
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcityhash.so' links to system library 'm' but it is not in cpp_info.system_libs.

@SpaceIm SpaceIm closed this Jan 11, 2023
@SpaceIm SpaceIm reopened this Jan 11, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 8 (73453443ca1f9bcba217cc074682df0f25059f77):

  • cityhash/cci.20130801@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 4c8a3e6 into conan-io:master Jan 12, 2023
@SpaceIm SpaceIm deleted the cityhash-conan-v2 branch January 12, 2023 08:19
AbrilRBS pushed a commit to AbrilRBS/conan-center-index that referenced this pull request Jan 16, 2023
* conan v2 support

* modernize more

* modernize more

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants