Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libaec: upgrade for conan v2 #13622

Merged
merged 6 commits into from
Oct 21, 2022
Merged

libaec: upgrade for conan v2 #13622

merged 6 commits into from
Oct 21, 2022

Conversation

paulharris
Copy link
Contributor

A relatively simple upgrade (I hope - lets see the reviews),
This is used as an option for HDF5.

@paulharris
Copy link
Contributor Author

QUESTION: The upstream libaec provides cmake files that allow libaec to pose as szip,
ie it generates SZIP_LIBRARIES, SZIP_FOUND, etc.

We don't want to support that in Conan, right?

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 20, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries previously approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

recipes/libaec/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libaec/all/conanfile.py Outdated Show resolved Hide resolved
@uilianries
Copy link
Member

QUESTION: The upstream libaec provides cmake files that allow libaec to pose as szip, ie it generates SZIP_LIBRARIES, SZIP_FOUND, etc.

We don't want to support that in Conan, right?

No.

paulharris and others added 2 commits October 20, 2022 20:51
@paulharris @uilianries
Update recipes/libaec/all/conanfile.py
b3ca1ea 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@paulharris @uilianries
Update recipes/libaec/all/conanfile.py
774dcc9 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 5 (774dcc9b1a9306e7a8b929ac928ae3d80a9bba8a):

  • libaec/1.0.6@:
    All packages built successfully! (All logs)

  • libaec/1.0.4@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 5d069ec into conan-io:master Oct 21, 2022
@paulharris paulharris deleted the libaec-conan-v2 branch October 21, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries approved these changes

@toge toge toge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulharris @conan-center-bot @uilianries @toge @jwillikers