[cmake-template] Simplify test_v1_package CMakeLists.txt #13656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
Don't need to copy again add_executable, target_link_libraries and so on,
just add test_package/ as sub_directory and run test_package/CMakeLists.txt
with conan_basic_setup(). Less lines to be maintained and reviewed.
…On Fri, Oct 21, 2022 at 10:28 AM SpaceIm ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/package_templates/cmake_package/all/test_v1_package/CMakeLists.txt
<#13656 (comment)>
:
> +add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/../test_package/
+ ${CMAKE_CURRENT_BINARY_DIR}/binaries/)
I don't understand
—
Reply to this email directly, view it on GitHub
<#13656 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFFAHLCHKHAUFWWAH5RRN3WEJH2BANCNFSM6AAAAAARK5DAI4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Cordialmente,
Uilian Ries
***@***.***>
|
jwillikers
approved these changes
Oct 21, 2022
jwillikers
suggested changes
Oct 21, 2022
| # in case the target project requires a C++ standard | ||
| target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17) | ||
| add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/../test_package/ | ||
| ${CMAKE_CURRENT_BINARY_DIR}/binaries/) |
There was a problem hiding this comment.
I think it makes more sense to name the binaries directory test_package so that we know what that belongs to in the build directory.
uilianries
commented
Oct 21, 2022
docs/package_templates/cmake_package/all/test_v1_package/CMakeLists.txt
Outdated
Show resolved
Hide resolved
jwillikers
approved these changes
Oct 21, 2022
prince-chrismc
approved these changes
Oct 22, 2022
|
Im in |
MartinDelille
added a commit
to MartinDelille/conan-center-index
that referenced
this pull request
Oct 24, 2022
conan-center-bot
pushed a commit
that referenced
this pull request
Dec 27, 2022
* [sentry-crashpad/xxx] conan v2 migration * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * Apply suggestions from code review Add CMakeDeps Co-authored-by: Uilian Ries <uilianries@gmail.com> * Add test_v1_package * Fix various issues * Minor fixes * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use export_conandata_patches * Move generate after source * Move layout after validate * Simpler test_v1_package from #13656 * Add libcurl requirement * Update to conan 1.53.0 * Revert "Update to conan 1.53.0" This reverts commit 01ed5d1. * Restore test_package crashpad_handler call * Fix linter error in conandata.yml * Fix cmake_layout path * Use cmake.configure(build_script_folder="external/crashpad") * Bump requirements * Fix handler_bin_path * Fix handler_exe on Windows * deps_cpp_info => dependencies * Dump info to understand what is going wrong on the ci * Revert "Dump info to understand what is going wrong on the ci" This reverts commit 708f716. * Fix test_v1_package * dependencies => deps_cpp_info * Add version 0.5.3 * Update recipes/sentry-crashpad/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
AbrilRBS
pushed a commit
to AbrilRBS/conan-center-index
that referenced
this pull request
Jan 16, 2023
* [sentry-crashpad/xxx] conan v2 migration * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * Apply suggestions from code review Add CMakeDeps Co-authored-by: Uilian Ries <uilianries@gmail.com> * Add test_v1_package * Fix various issues * Minor fixes * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Use export_conandata_patches * Move generate after source * Move layout after validate * Simpler test_v1_package from conan-io#13656 * Add libcurl requirement * Update to conan 1.53.0 * Revert "Update to conan 1.53.0" This reverts commit 01ed5d1. * Restore test_package crashpad_handler call * Fix linter error in conandata.yml * Fix cmake_layout path * Use cmake.configure(build_script_folder="external/crashpad") * Bump requirements * Fix handler_bin_path * Fix handler_exe on Windows * deps_cpp_info => dependencies * Dump info to understand what is going wrong on the ci * Revert "Dump info to understand what is going wrong on the ci" This reverts commit 708f716. * Fix test_v1_package * dependencies => deps_cpp_info * Add version 0.5.3 * Update recipes/sentry-crashpad/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating, let's re-use from test_package/