Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl: honor default upstream values of with_ca_bundle & with_ca_path options #13914

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Nov 1, 2022

closes #13910

Some explanation: #13910 (comment)


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

@LunarWatcher Please let us know if this solves your issue 🤞

@LunarWatcher
Copy link
Contributor

I haven't had the chance to look at it yet, but planning to get to it within a couple hours. Will let you know when I've tested.

@prince-chrismc
Copy link
Contributor

Do we not install the cli tool? maybe we could run that

with a simple get one a "local" resource to make sure the it's working?

@prince-chrismc
Copy link
Contributor

I haven't had the chance to look at it yet, but planning to get to it within a couple hours. Will let you know when I've tested.

❤️ thats soo much !

@LunarWatcher
Copy link
Contributor

LunarWatcher commented Nov 1, 2022

Sorry for the delay, took me a little bit to figure out the test setup and test build. I can confirm it works; the bundle is listed in the config, and the test from the issue works like it's meant to now.

configure: Configured to build curl/libcurl:

  Host setup:       x86_64-pc-linux-gnu
  Install prefix:   /
  Compiler:         clang
   CFLAGS:          -m64 -fPIC -O3 -Qunused-arguments
   CPPFLAGS:        -DNDEBUG -isystem /home/olivia/.conan/data/zlib/1.2.13/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/include -isystem /home/olivia/.conan/data/openssl/1.1.1q/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/include -isystem /home/olivia/.conan/data/zlib/1.2.13/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/include -isystem /home/olivia/.conan/data/openssl/1.1.1q/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/include -isystem /home/olivia/.conan/data/openssl/1.1.1q/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/include/openssl
   LDFLAGS:         -m64 -L/home/olivia/.conan/data/zlib/1.2.13/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/lib -L/home/olivia/.conan/data/openssl/1.1.1q/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/lib -L/home/olivia/.conan/data/zlib/1.2.13/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/lib -L/home/olivia/.conan/data/openssl/1.1.1q/_/_/package/24d596ecc3e7cfef35630620092c5615473ba82a/lib
   LIBS:            -lssl -lcrypto -lz -lz -lssl -lcrypto -ldl -lpthread -lrt

  curl version:     7.80.0
  SSL:              enabled (OpenSSL)
  SSH:              no      (--with-{libssh,libssh2})
  zlib:             enabled
  brotli:           no      (--with-brotli)
  zstd:             no      (--with-zstd)
  GSS-API:          no      (--with-gssapi)
  GSASL:            no      (libgsasl not found)
  TLS-SRP:          enabled
  resolver:         POSIX threaded
  IPv6:             enabled
  Unix sockets:     enabled
  IDN:              no      (--with-{libidn2,winidn})
  Build libcurl:    Shared=no, Static=yes
  Built-in manual:  no      (--enable-manual)
  --libcurl option: enabled (--disable-libcurl-option)
  Verbose errors:   enabled (--disable-verbose)
  Code coverage:    disabled
  SSPI:             no      (--enable-sspi)
  ca cert bundle:   /etc/ssl/certs/ca-certificates.crt
  ca cert path:     no
  ca fallback:      no
  LDAP:             no      (--enable-ldap / --with-ldap-lib / --with-lber-lib)
  LDAPS:            no      (--enable-ldaps)
  RTSP:             enabled
  RTMP:             no      (--with-librtmp)
  PSL:              no      (--with-libpsl)
  Alt-svc:          enabled (--disable-alt-svc)
  HSTS:             enabled (--disable-hsts)
  HTTP1:            enabled (internal)
  HTTP2:            no      (--with-nghttp2, --with-hyper)
  HTTP3:            no      (--with-ngtcp2, --with-quiche)
  ECH:              no      (--enable-ech)
  Protocols:        DICT FILE FTP FTPS GOPHER GOPHERS HTTP HTTPS IMAP IMAPS MQTT POP3 POP3S RTSP SMB SMBS SMTP SMTPS TELNET TFTP
  Features:         AsynchDNS HSTS HTTPS-proxy IPv6 Largefile NTLM NTLM_WB SSL TLS-SRP UnixSockets alt-svc libz
-- Conan: Adjusting output directories
-- Conan: Using cmake global configuration
-- Conan: Adjusting default RPATHs Conan policies
-- Conan: Adjusting language standard
-- Current conanbuildinfo.cmake directory: /home/olivia/build/bad-libcurl/build
-- Conan: Compiler Clang>=8, checking major version 14
-- Conan: Checking correct version: 14
-- Configuring done
-- Generating done
-- Build files have been written to: /home/olivia/build/bad-libcurl/build

❯ make
[ 50%] Building CXX object CMakeFiles/bad-libcurl.dir/Main.cpp.o
[100%] Linking CXX executable bin/bad-libcurl
[100%] Built target bad-libcurl

❯ ./bin/bad-libcurl 
Status code: 200
Fail: 
(empty is good, I didn't bother adding a conditional for whether the "Fail" bit should be printed if there isn't an error message because I'm lazy :p)

So yeah, this PR fixes it. Thank you!

@prince-chrismc
Copy link
Contributor

Fail:
(empty is good, I didn't bother adding a conditional for whether the "Fail" bit should be printed if there isn't an error message because I'm lazy :p)

Just made my day! Cheers!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 2 (f468b32ece093a40e99a7b6558fd30404bdec7c7):

  • libcurl/7.83.1@:
    All packages built successfully! (All logs)

  • libcurl/7.76.0@:
    All packages built successfully! (All logs)

  • libcurl/7.78.0@:
    All packages built successfully! (All logs)

  • libcurl/7.82.0@:
    All packages built successfully! (All logs)

  • libcurl/7.77.0@:
    All packages built successfully! (All logs)

  • libcurl/7.84.0@:
    All packages built successfully! (All logs)

  • libcurl/7.79.1@:
    All packages built successfully! (All logs)

  • libcurl/7.80.0@:
    All packages built successfully! (All logs)

  • libcurl/7.85.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 240e11b into conan-io:master Nov 4, 2022
@SpaceIm SpaceIm deleted the libcurl-ca-bundle-path branch November 4, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] libcurl/7.80.0: "unable to get local issuer certificate" following some update to the package
5 participants