Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libev: msvc support #14138

Merged
merged 8 commits into from
Jan 27, 2023
Merged

libev: msvc support #14138

merged 8 commits into from
Jan 27, 2023

Conversation

xakod
Copy link
Contributor

@xakod xakod commented Nov 10, 2022

Specify library name and version: libev

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Nov 10, 2022

I detected other pull requests that are modifying libev/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Nov 10, 2022
4 tasks
@xakod
Copy link
Contributor Author

xakod commented Nov 10, 2022

Wait for #14061

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Anton and others added 3 commits January 9, 2023 09:31
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

prince-chrismc
prince-chrismc previously approved these changes Jan 9, 2023
@conan-center-bot

This comment has been minimized.

prince-chrismc
prince-chrismc previously approved these changes Jan 25, 2023
Copy link
Contributor

@SpaceIm SpaceIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I had in mind

recipes/libev/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libev/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libev/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (b4d55bbf853adfb5a81a39aad4672de92c5737be):

  • libev/4.33@:
    All packages built successfully! (All logs)

  • libev/4.25@:
    All packages built successfully! (All logs)

  • libev/4.27@:
    All packages built successfully! (All logs)

@xakod xakod requested review from SpaceIm and removed request for uilianries January 25, 2023 13:02
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit a868858 into conan-io:master Jan 27, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* libev for msvc

* * remove cmake from patch

* Apply suggestions from code review

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* * remove config from patch

* * conanfile depended export

* * remove patches

* do not copy CMakeLists to src folder

* Apply suggestions from code review

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@xakod xakod deleted the libev-msvc branch March 3, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants