-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: rely on tools.apple:enable_bitcode
conf instead of a custom option
#14139
boost: rely on tools.apple:enable_bitcode
conf instead of a custom option
#14139
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there. |
@@ -1116,7 +1109,7 @@ def add_defines(library): | |||
if self.options.multithreading: | |||
cxx_flags.append("-DBOOST_SP_USE_SPINLOCK") | |||
|
|||
if "embed_bitcode" in self.options and self.options.embed_bitcode: | |||
if self.conf.get("tools.apple:enable_bitcode", check_type=bool): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember that, whenever this recipe will be migrated, we should remove these lines because, with that configuration enabled, CMakeToolchain
will automatically add that bitcode flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boost is not built with CMake (yet?), but b2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put money on Boost never switching from b2
to CMake
.
Conan v1 pipelineAll green in build 1 (
|
Hooks produced the following warnings for commit 4d0bd48boost/1.76.0
boost/1.79.0
boost/1.71.0
boost/1.73.0
boost/1.70.0
boost/1.72.0
boost/1.75.0
boost/1.80.0
boost/1.74.0
boost/1.78.0
boost/1.77.0
|
remove option introduced in #13970, bitcode is a first class citizen of conan v2 through
tools.apple:enable_bitcode
(but it must be manually handled in build system without conan build helpers).