Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libffi - fix to support updated automake recipe #14460

Closed
wants to merge 1 commit into from
Closed

libffi - fix to support updated automake recipe #14460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions recipes/libffi/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,12 @@ def generate(self):
compile_wrapper = unix_path(self, os.path.join(self.source_folder, "msvcc.sh"))
if architecture_flag:
compile_wrapper = f"{compile_wrapper} {architecture_flag}"
# FIXME: Use the conf once https://github.com/conan-io/conan-center-index/pull/12898 is merged
# env.define("AR", f"{unix_path(self, self.conf.get('tools.automake:ar-lib'))}")
[version_major, version_minor, _] = self.dependencies.direct_build['automake'].ref.version.split(".", 2)
automake_version = f"{version_major}.{version_minor}"
ar_wrapper = unix_path(self, os.path.join(self.dependencies.direct_build['automake'].cpp_info.resdirs[0], f"automake-{automake_version}", "ar-lib"))
env.define("CC", f"{compile_wrapper}")
env.define("CXX", f"{compile_wrapper}")
env.define("LD", "link -nologo")
env.define("AR", f"{ar_wrapper} \"lib -nologo\"")
Comment on lines -134 to -138
Copy link
Contributor

@SpaceIm SpaceIm Nov 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automake doesn't yet define this conf, and the fix here is not correct. Not sure it's worth struggling c3i for something we know fails for the moment.

env.define("AR", f"{unix_path(self, self.conf.get('user.automake:ar-lib'))}")
env.define("NM", "dumpbin -symbols")
env.define("OBJDUMP", ":")
env.define("RANLIB", ":")
Expand Down