-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix soxr for Apple Silicon architecture #14489
Conversation
This comment has been minimized.
This comment has been minimized.
You'll need to update the recipe's imports to the latest version for the bot to merge 😄 |
I updated the recipe for Conan V2 and hope the bot is happy now. :) |
This comment has been minimized.
This comment has been minimized.
wow! amawing! you only need to change the imports but new Toolchain is 🤩 |
This comment has been minimized.
This comment has been minimized.
The CI still failes. Some jobs create shared libraries instead of static ones and I don't know why. On my local it is the same but only for Conan V1, with V2 the static libs are created as expected. BTW: Do I see it correctly that your CI can already build for M1? |
Thats correct M1 is testing and the binaries are available :) |
Most likely you will need to set this to NEW for it to work conan-center-index/recipes/re2/all/conanfile.py Lines 50 to 51 in 2ecc63a
|
This comment has been minimized.
This comment has been minimized.
Thanks @prince-chrismc! I think that helped but the CI is still failing and I don't find the reason for that in the logs. |
You need to follow the links :) https://c3i.jfrog.io/c3i/misc/logs/pr/14489/6-linux-gcc/soxr/0.1.3//14780ca7ef11429d1c9848b4e2d92d076916cce8-test.txt
|
Now I see it. Sorry, I did look at the bottom of the log. :) I'll have a look again, but I fear Im not sure again what the problem is. |
@prince-chrismc Do you know why it is using the |
It's a migration thing, if you look for that line you'll find it in another recipes and you'll be able to see what the new version should be. I am flying home later so ill be around during the week to help better |
Actually I got that line from a different recipe, I think it was Catch2:
The only difference I can see is that there it is called in generate() and I call it in test() . The documentation however does not state that it is not available in test() , but it says it should only be called from generate() and validate() so I guess it is just not implemented yet, right?
Thanks a lot for your help! It is very much appreciated! |
Me: "Oh that's an excellent question let me write some docs for it!" 🤦 So this is by decision, the "complete" graph is limited to The docs should be good to copy past, there is also the |
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
54d574f
to
da860ca
Compare
Thanks for your answer and no worries! I had not much time to work on this anyway. :) I took the code now from |
CI seemed to have a random failure downloading java deps 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small comments but looks super good
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Conan v1 pipelineAll green in build 11 (
Conan v2 pipeline (informative, not required for merge)Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
* Fix soxr for Apple Silicon architecture * Prepare for Conan v2 * Set test_type explicit for the new test_package Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Use `can_run` instead of `not cross_building` in the test_package Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Remove wrapper CMakeLists.txt * Declare some CMake policies * Fix test_package for Conan v1 * Add patch descriptions and types * Change todos filename Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update minimum required Conan version Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Hey!) |
Hi @flak228 I think it'd be great to open an issue in this repository https://github.com/conan-io/conan-center-index/issues/new?assignees=&labels=question&projects=&template=question.yml&title=%5Bquestion%5D+SHORT+DESCRIPTION So we'll try our best to help you with that. Please, put all the necessary details about your use case there and how you are trying to use soxr. Thanks! |
Specify library name and version: soxr/0.1.3
This should fix #14485. At least it is a workaround to get soxr compiled for the Apple Silicon Macs. Im not an expert with this new architecture and SIMD, but for me it seems it is not supported by Apple Silicon.