Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doxygen] Add Version 1.9.5 and bump dependency versions #14490

Merged
merged 43 commits into from
Jan 27, 2023
Merged

[doxygen] Add Version 1.9.5 and bump dependency versions #14490

merged 43 commits into from
Jan 27, 2023

Conversation

Sneder89
Copy link
Contributor

@Sneder89 Sneder89 commented Nov 29, 2022 •
edited
Loading

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc previously approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a new helper for https://github.com/conan-io/conan-center-index/pull/14490/files#diff-cbfb36af247c5a661634bfa630c3f276104e89b382d6a6a1335e62e4b2d99930R101

but this looks good... just waiting on CI 🤞

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc previously approved these changes Jan 16, 2023
View reviewed changes
@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 16, 2023

Do not approve please. There is a regression is this PR: #14490 (comment)

SpaceIm
SpaceIm reviewed Jan 16, 2023
View reviewed changes
recipes/doxygen/all/conanfile.py Outdated
Comment on lines 88 to 90
# if self.settings.os != "Windows":
# deps.set_property("flex", "cmake_find_mode", "none", build_context=True)
# deps.set_property("bison", "cmake_find_mode", "none", build_context=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# if self.settings.os != "Windows":
# deps.set_property("flex", "cmake_find_mode", "none", build_context=True)
# deps.set_property("bison", "cmake_find_mode", "none", build_context=True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines are deleted in recipe

@conan-center-bot

This comment has been minimized.

Sign in to view
SpaceIm
SpaceIm suggested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@SpaceIm SpaceIm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't safely use settings_build with 1 profile, you have to restore helper _settings_build you have removed.

Also notice that you can accept reviews as commits in github.

recipes/doxygen/all/conanfile.py Outdated

def build_requirements(self):
if self._settings_build.os == "Windows":
self.build_requires("winflexbison/2.5.24")
if self.settings.os == "Windows":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.settings.os == "Windows":
if self._settings_build.os == "Windows":

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous logic is applied

recipes/doxygen/all/conanfile.py Show resolved Hide resolved
Sneder89 and others added 2 commits January 16, 2023 14:54
@Sneder89 @SpaceIm
Update recipes/doxygen/all/conanfile.py
4814180 
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@Sneder89
Update conanfile.py
9f3e914
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 42 (9f3e91426bcba922d4aeacac46bec3faa38ddb7c):

  • doxygen/1.9.1@:
    All packages built successfully! (All logs)

  • doxygen/1.9.4@:
    All packages built successfully! (All logs)

  • doxygen/1.9.2@:
    All packages built successfully! (All logs)

  • doxygen/1.8.18@:
    All packages built successfully! (All logs)

  • doxygen/1.8.17@:
    All packages built successfully! (All logs)

  • doxygen/1.8.20@:
    All packages built successfully! (All logs)

@Sneder89 Sneder89 requested review from prince-chrismc and SpaceIm and removed request for prince-chrismc January 18, 2023 21:15
@prince-chrismc
Copy link
Contributor

We will be dropping 1.x support as soon as possible... so support 1 profiles is not a requirement :) we break recipes all the time.

In this case it's not complicated to support so I think it's good to keep it but it's not test by CCI so if it works great if not we'll never know 🤷

@conan-center-bot conan-center-bot requested review from jcar87 and removed request for SpaceIm January 26, 2023 12:02
uilianries
uilianries approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit c1eb2ba into conan-io:master Jan 27, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
@Sneder89 @SpaceIm @StellaSmith
(conan-io#14490) [doxygen] Add Version 1.9.5 and bump dependency vers…
350a1d6 
…ions

* add 1.9.5 entries and bump dependeny versions

* Update conanfile.py

* remove unnecessary patch files

* Update conanfile.py

* add m4

* add v1 test package

* remove deps generator

* return to old codebase

* apply patches

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* remove weird cmake configure function

* Update conandata.yml

* remove CONAN_PKG

* remove unused patches

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* use visualmstudio 16

* Update conanfile.py

* remove version 1.9.5

* Update conanfile.py

use 2.0 cmake tools

* use patch file

* Update conanfile.py

* remove unused imports

* make the package v2 compatible

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update conanfile.py

* Update recipes/doxygen/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Update conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm requested changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sneder89 @conan-center-bot @SpaceIm @prince-chrismc @uilianries